Skip to content

Commit 899b8e1

Browse files
committed
chore: Adjust doc comment, add TODO dev comment
1 parent 99617d2 commit 899b8e1

1 file changed

Lines changed: 6 additions & 3 deletions

File tree

crates/stackable-operator/src/commons/secret_class.rs

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -99,10 +99,13 @@ pub struct SecretClassVolumeScope {
9999
pub listener_volumes: Vec<String>,
100100
}
101101

102-
/// What parts secret-operator should provision into the requested volume.
102+
/// What parts of secret material should be provisioned into the requested volume.
103103
//
104-
// There intentionally isn't a global [`Default`] impl, as it's secret-ops concern what it chooses
105-
// as a default.
104+
// There intentionally isn't a global [`Default`] impl, as it is secret-operator's concern what it
105+
// chooses as a default.
106+
// TODO (@Techassi): This to me is a HUGE indicator this lives in the wrong place. All these secret
107+
// volume builders/helpers should be defined as part of a secret-operator library to be as close as
108+
// possible to secret-operator, which is the authoritative source of truth for all of this.
106109
#[derive(Copy, Clone, Debug, PartialEq, Eq, strum::AsRefStr)]
107110
#[strum(serialize_all = "kebab-case")]
108111
pub enum SecretClassVolumeProvisionParts {

0 commit comments

Comments
 (0)