clippy::use_self

Author: sbernauer

crates/stackable-operator/src/builder/configmap.rs

@@ -19,8 +19,8 @@ pub struct ConfigMapBuilder {
 }
 
 impl ConfigMapBuilder {
-    pub fn new() -> ConfigMapBuilder {
-        ConfigMapBuilder::default()
+    pub fn new() -> Self {
+        Self::default()
     }
 
     pub fn metadata_default(&mut self) -> &mut Self {

crates/stackable-operator/src/builder/event.rs

@@ -34,7 +34,7 @@ impl EventBuilder {
     /// # Arguments
     ///
     /// - `resource` - The resource for which this event is created, will be used to create the `involvedObject` and `metadata.name` fields
-    pub fn new<T>(resource: &T) -> EventBuilder
+    pub fn new<T>(resource: &T) -> Self
     where
         T: Resource<DynamicType = ()>,
     {
@@ -48,10 +48,10 @@ impl EventBuilder {
             uid: resource.meta().uid.clone(),
         };
 
-        EventBuilder {
+        Self {
             name: resource.name_any(),
             involved_object,
-            ..EventBuilder::default()
+            ..Self::default()
         }
     }
 

crates/stackable-operator/src/builder/meta.rs

@@ -34,8 +34,8 @@ pub struct ObjectMetaBuilder {
 }
 
 impl ObjectMetaBuilder {
-    pub fn new() -> ObjectMetaBuilder {
-        ObjectMetaBuilder::default()
+    pub fn new() -> Self {
+        Self::default()
     }
 
     /// This sets the name and namespace from a given resource
@@ -228,8 +228,8 @@ pub struct OwnerReferenceBuilder {
 }
 
 impl OwnerReferenceBuilder {
-    pub fn new() -> OwnerReferenceBuilder {
-        OwnerReferenceBuilder::default()
+    pub fn new() -> Self {
+        Self::default()
     }
 
     pub fn api_version(&mut self, api_version: impl Into<String>) -> &mut Self {

crates/stackable-operator/src/builder/pdb.rs

@@ -59,7 +59,7 @@ pub enum PodDisruptionBudgetConstraint {
 
 impl PodDisruptionBudgetBuilder<(), (), ()> {
     pub fn new() -> Self {
-        PodDisruptionBudgetBuilder::default()
+        Self::default()
     }
 
     /// This method populates [`PodDisruptionBudget::metadata`] and

crates/stackable-operator/src/builder/pod/container.rs

@@ -67,9 +67,9 @@ pub struct ContainerBuilder {
 impl ContainerBuilder {
     pub fn new(name: &str) -> Result<Self> {
         Self::validate_container_name(name)?;
-        Ok(ContainerBuilder {
+        Ok(Self {
             name: name.to_string(),
-            ..ContainerBuilder::default()
+            ..Self::default()
         })
     }
 
@@ -371,9 +371,9 @@ pub struct ContainerPortBuilder {
 
 impl ContainerPortBuilder {
     pub fn new(container_port: i32) -> Self {
-        ContainerPortBuilder {
+        Self {
             container_port,
-            ..ContainerPortBuilder::default()
+            ..Self::default()
         }
     }
 
@@ -422,11 +422,11 @@ pub enum FieldPathEnvVar {
 impl fmt::Display for FieldPathEnvVar {
     fn fmt(&self, f: &mut fmt::Formatter) -> fmt::Result {
         match self {
-            FieldPathEnvVar::Name => write!(f, "metadata.name"),
-            FieldPathEnvVar::Namespace => write!(f, "metadata.namespace"),
-            FieldPathEnvVar::UID => write!(f, "metadata.uid"),
-            FieldPathEnvVar::Labels(name) => write!(f, "metadata.labels['{name}']"),
-            FieldPathEnvVar::Annotations(name) => write!(f, "metadata.annotations['{name}']"),
+            Self::Name => write!(f, "metadata.name"),
+            Self::Namespace => write!(f, "metadata.namespace"),
+            Self::UID => write!(f, "metadata.uid"),
+            Self::Labels(name) => write!(f, "metadata.labels['{name}']"),
+            Self::Annotations(name) => write!(f, "metadata.annotations['{name}']"),
         }
     }
 }

crates/stackable-operator/src/builder/pod/mod.rs

@@ -88,8 +88,8 @@ pub struct PodBuilder {
 }
 
 impl PodBuilder {
-    pub fn new() -> PodBuilder {
-        PodBuilder::default()
+    pub fn new() -> Self {
+        Self::default()
     }
 
     pub fn service_account_name(&mut self, value: impl Into<String>) -> &mut Self {

crates/stackable-operator/src/builder/pod/resources.rs

@@ -24,7 +24,7 @@ pub struct ResourceRequirementsBuilder<CR, CL, MR, ML> {
 
 impl ResourceRequirementsBuilder<(), (), (), ()> {
     pub fn new() -> Self {
-        ResourceRequirementsBuilder::default()
+        Self::default()
     }
 }
 

crates/stackable-operator/src/builder/pod/security.rs

@@ -18,8 +18,8 @@ impl SecurityContextBuilder {
         }
     }
 
-    pub fn new() -> SecurityContextBuilder {
-        SecurityContextBuilder::default()
+    pub fn new() -> Self {
+        Self::default()
     }
 
     pub fn allow_privilege_escalation(&mut self, value: bool) -> &mut Self {
@@ -150,8 +150,8 @@ pub struct PodSecurityContextBuilder {
 }
 
 impl PodSecurityContextBuilder {
-    pub fn new() -> PodSecurityContextBuilder {
-        PodSecurityContextBuilder::default()
+    pub fn new() -> Self {
+        Self::default()
     }
 
     pub fn build(&self) -> PodSecurityContext {

crates/stackable-operator/src/builder/pod/volume.rs

@@ -48,10 +48,10 @@ impl Default for VolumeSource {
 }
 
 impl VolumeBuilder {
-    pub fn new(name: impl Into<String>) -> VolumeBuilder {
-        VolumeBuilder {
+    pub fn new(name: impl Into<String>) -> Self {
+        Self {
             name: name.into(),
-            ..VolumeBuilder::default()
+            ..Self::default()
         }
     }
 
@@ -222,11 +222,11 @@ pub struct VolumeMountBuilder {
 }
 
 impl VolumeMountBuilder {
-    pub fn new(name: impl Into<String>, mount_path: impl Into<String>) -> VolumeMountBuilder {
-        VolumeMountBuilder {
+    pub fn new(name: impl Into<String>, mount_path: impl Into<String>) -> Self {
+        Self {
             mount_path: mount_path.into(),
             name: name.into(),
-            ..VolumeMountBuilder::default()
+            ..Self::default()
         }
     }
 
@@ -428,10 +428,10 @@ impl ListenerReference {
     /// Return the key and value for a Kubernetes object annotation
     fn to_annotation(&self) -> Result<Annotation, AnnotationError> {
         match self {
-            ListenerReference::ListenerClass(class) => {
+            Self::ListenerClass(class) => {
                 Annotation::try_from(("listeners.stackable.tech/listener-class", class.as_str()))
             }
-            ListenerReference::ListenerName(name) => {
+            Self::ListenerName(name) => {
                 Annotation::try_from(("listeners.stackable.tech/listener-name", name.as_str()))
             }
         }
@@ -493,7 +493,7 @@ impl ListenerOperatorVolumeSourceBuilder {
     pub fn new(
         listener_reference: &ListenerReference,
         labels: &Labels,
-    ) -> ListenerOperatorVolumeSourceBuilder {
+    ) -> Self {
         Self {
             listener_reference: listener_reference.to_owned(),
             labels: labels.to_owned(),

crates/stackable-operator/src/client.rs

@@ -113,7 +113,7 @@ impl Client {
         default_namespace: String,
         kubernetes_cluster_info: KubernetesClusterInfo,
     ) -> Self {
-        Client {
+        Self {
             client,
             post_params: PostParams {
                 field_manager: field_manager.clone(),