refactor!: Take IntoIterator<Item = EnvVar> instead

Author: sbernauer

crates/stackable-operator/CHANGELOG.md

@@ -8,7 +8,13 @@ All notable changes to this project will be documented in this file.
 
 - Add support for specifying a `clientAuthenticationMethod` for OIDC ([#1178]).
   This was originally done in [#1158] and had been reverted in [#1170].
+- Add generic database connection mechanism ([#1163])
 
+### Changed
+
+- BREAKING: Change signature of `ContainerBuilder::add_env_vars` from `Vec<EnvVar>` to `IntoIterator<Item = EnvVar>` ([#1163])
+
+[#1163]: https://github.com/stackabletech/operator-rs/pull/1163
 [#1178]: https://github.com/stackabletech/operator-rs/pull/1178
 
 ## [0.108.0] - 2026-03-10

crates/stackable-operator/src/builder/pod/container.rs

@@ -1,4 +1,4 @@
-use std::{borrow::Borrow, fmt};
+use std::fmt;
 
 use indexmap::IndexMap;
 use k8s_openapi::api::core::v1::{
@@ -177,12 +177,9 @@ impl ContainerBuilder {
 
     pub fn add_env_vars<I>(&mut self, env_vars: I) -> &mut Self
     where
-        I: IntoIterator,
-        I::Item: std::borrow::Borrow<EnvVar>,
+        I: IntoIterator<Item = EnvVar>,
     {
-        self.env
-            .get_or_insert_with(Vec::new)
-            .extend(env_vars.into_iter().map(|e| e.borrow().clone()));
+        self.env.get_or_insert_with(Vec::new).extend(env_vars);
         self
     }
 

crates/stackable-operator/src/crd/git_sync/v1alpha1_impl.rs

@@ -197,7 +197,7 @@ impl GitSyncResources {
                 one_time,
                 container_log_config,
             )])
-            .add_env_vars(env_vars)
+            .add_env_vars(env_vars.iter().cloned())
             .add_volume_mounts(volume_mounts.to_vec())
             .context(AddVolumeMountSnafu)?
             .resources(

crates/stackable-operator/src/crd/git_sync/v1alpha2_impl.rs

@@ -241,7 +241,7 @@ impl GitSyncResources {
                 one_time,
                 container_log_config,
             )])
-            .add_env_vars(env_vars)
+            .add_env_vars(env_vars.iter().cloned())
             .add_volume_mounts(volume_mounts.to_vec())
             .context(AddVolumeMountSnafu)?
             .resources(

crates/stackable-operator/src/databases/drivers/celery.rs

@@ -68,7 +68,7 @@ impl CeleryDatabaseConnectionDetails {
     }
 
     pub fn add_to_container(&self, cb: &mut ContainerBuilder) {
-        cb.add_env_vars(self.env_vars());
+        cb.add_env_vars(self.env_vars().cloned());
     }
 }
 

crates/stackable-operator/src/databases/drivers/jdbc.rs

@@ -57,7 +57,7 @@ pub struct JDBCDatabaseConnectionDetails {
 impl JDBCDatabaseConnectionDetails {
     pub fn add_to_container(&self, cb: &mut ContainerBuilder) {
         let env_vars = self.username_env.iter().chain(self.password_env.iter());
-        cb.add_env_vars(env_vars);
+        cb.add_env_vars(env_vars.cloned());
     }
 }
 

crates/stackable-operator/src/databases/drivers/sqlalchemy.rs

@@ -68,7 +68,7 @@ impl SQLAlchemyDatabaseConnectionDetails {
     }
 
     pub fn add_to_container(&self, cb: &mut ContainerBuilder) {
-        cb.add_env_vars(self.env_vars());
+        cb.add_env_vars(self.env_vars().cloned());
     }
 }