File tree Expand file tree Collapse file tree
crates/stackable-operator Expand file tree Collapse file tree Original file line number Diff line number Diff line change @@ -8,6 +8,7 @@ All notable changes to this project will be documented in this file.
88
99- BREAKING: ` PodSecurityContextBuilder::new ` was removed in favor of ` PodSecurityContextBuilder::with_stackable_defaults ` ([ #XXXX] ).
1010 This function already sets up some defaults we want to use across the platform.
11+ Currently this is ` runAsNonRoot: true ` , which might cause product Pods to crash and require changes.
1112- BREAKING: ` PodSecurityContextBuilder::run_as_non_root ` now takes a ` bool ` instead of assuming consumers always want to set it to ` true ` ([ #XXXX] ).
1213 This is needed to allow users setting it to ` false ` in case the new ` with_stackable_defaults ` functions set's it to ` true ` .
1314
Original file line number Diff line number Diff line change @@ -163,6 +163,10 @@ pub struct PodSecurityContextBuilder {
163163
164164impl PodSecurityContextBuilder {
165165 /// Construct a new [`PodSecurityContextBuilder`] that is pre-filled with Stackable's defaults.
166+ ///
167+ /// Currently the defaults are:
168+ ///
169+ /// * `runAsNonRoot: true`
166170 pub fn with_stackable_defaults ( ) -> Self {
167171 Self {
168172 pod_security_context : Self :: stackable_default_pod_security_context ( ) ,
@@ -172,10 +176,8 @@ impl PodSecurityContextBuilder {
172176 /// The Stackable's defaults for a [`PodSecurityContext`].
173177 ///
174178 /// It is recommended to use the [`PodSecurityContextBuilder::with_stackable_defaults`] instead
175- /// (if possible).
179+ /// (if possible). Have a look at it's documentation for details.
176180 pub fn stackable_default_pod_security_context ( ) -> PodSecurityContext {
177- todo ! ( "Lars needs to define the exact settings he wants" ) ;
178-
179181 PodSecurityContext {
180182 run_as_non_root : Some ( true ) ,
181183 ..Default :: default ( )
You can’t perform that action at this time.
0 commit comments