chore: Improve code style

Author: siegfriedweber

crates/stackable-operator/src/crd/git_sync/v1alpha1_impl.rs

@@ -164,7 +164,7 @@ impl GitSyncResources {
                 resolved_product_image,
                 git_sync,
                 false,
-                &Vec::from(env_vars.clone()),
+                env_vars.clone(),
                 &git_sync_container_volume_mounts,
                 container_log_config,
             )?;
@@ -174,7 +174,7 @@ impl GitSyncResources {
                 resolved_product_image,
                 git_sync,
                 true,
-                &Vec::from(env_vars),
+                env_vars,
                 &git_sync_container_volume_mounts,
                 container_log_config,
             )?;
@@ -214,7 +214,7 @@ impl GitSyncResources {
         resolved_product_image: &ResolvedProductImage,
         git_sync: &GitSync,
         one_time: bool,
-        env_vars: &[EnvVar],
+        env_vars: EnvVarSet,
         volume_mounts: &[VolumeMount],
         container_log_config: &ContainerLogConfig,
     ) -> Result<k8s_openapi::api::core::v1::Container, Error> {
@@ -234,7 +234,7 @@ impl GitSyncResources {
                 one_time,
                 container_log_config,
             )])
-            .add_env_vars(env_vars.iter().cloned())
+            .add_env_vars(env_vars)
             .add_volume_mounts(volume_mounts.to_vec())
             .context(AddVolumeMountSnafu)?
             .resources(

crates/stackable-operator/src/crd/git_sync/v1alpha2_impl.rs

@@ -257,7 +257,7 @@ impl GitSyncResources {
                 resolved_product_image,
                 git_sync,
                 false,
-                &Vec::from(env_vars.clone()),
+                env_vars.clone(),
                 &git_sync_container_volume_mounts,
                 container_log_config,
                 ca_cert_path.as_deref(),
@@ -268,7 +268,7 @@ impl GitSyncResources {
                 resolved_product_image,
                 git_sync,
                 true,
-                &Vec::from(env_vars),
+                env_vars,
                 &git_sync_container_volume_mounts,
                 container_log_config,
                 ca_cert_path.as_deref(),
@@ -331,7 +331,7 @@ impl GitSyncResources {
         resolved_product_image: &ResolvedProductImage,
         git_sync: &GitSync,
         one_time: bool,
-        env_vars: &[EnvVar],
+        env_vars: EnvVarSet,
         volume_mounts: &[VolumeMount],
         container_log_config: &ContainerLogConfig,
         ca_cert_path: Option<&str>,
@@ -353,7 +353,7 @@ impl GitSyncResources {
                 container_log_config,
                 ca_cert_path,
             )])
-            .add_env_vars(env_vars.iter().cloned())
+            .add_env_vars(env_vars)
             .add_volume_mounts(volume_mounts.to_vec())
             .context(AddVolumeMountSnafu)?
             .resources(