Fix clippy lints

Author: sbernauer

crates/stackable-certs/src/ca/mod.rs

@@ -128,7 +128,8 @@ where
 {
     #[snafu(display("failed to retrieve secret \"{secret_ref}\""))]
     GetSecret {
-        source: kube::Error,
+        #[snafu(source(from(kube::Error, Box::new)))]
+        source: Box<kube::Error>,
         secret_ref: SecretReference,
     },
 
@@ -146,15 +147,19 @@ where
 
     #[snafu(display("failed to read PEM-encoded certificate chain from secret {secret:?}"))]
     ReadChain {
-        source: x509_cert::der::Error,
+        #[snafu(source(from(x509_cert::der::Error, Box::new)))]
+        source: Box<x509_cert::der::Error>,
         secret: ObjectRef<Secret>,
     },
 
     #[snafu(display("failed to parse UTF-8 encoded byte string"))]
     DecodeUtf8String { source: std::str::Utf8Error },
 
     #[snafu(display("failed to deserialize private key from PEM"))]
-    DeserializeKeyFromPem { source: E },
+    DeserializeKeyFromPem {
+        #[snafu(source(from(E, Box::new)))]
+        source: Box<E>,
+    },
 }
 
 /// A certificate authority (CA) which is used to generate and sign

crates/stackable-operator/src/cluster_resources.rs

@@ -53,7 +53,10 @@ pub enum Error {
     MissingObjectKey { key: &'static str },
 
     #[snafu(display("failed to list cluster resources with label selector"))]
-    ListClusterResources { source: crate::client::Error },
+    ListClusterResources {
+        #[snafu(source(from(crate::client::Error, Box::new)))]
+        source: Box<crate::client::Error>,
+    },
 
     #[snafu(display("label {label:?} is missing"))]
     MissingLabel { label: &'static str },
@@ -68,13 +71,22 @@ pub enum Error {
     },
 
     #[snafu(display("failed to get resource"))]
-    GetResource { source: crate::client::Error },
+    GetResource {
+        #[snafu(source(from(crate::client::Error, Box::new)))]
+        source: Box<crate::client::Error>,
+    },
 
     #[snafu(display("failed to apply patch"))]
-    ApplyPatch { source: crate::client::Error },
+    ApplyPatch {
+        #[snafu(source(from(crate::client::Error, Box::new)))]
+        source: Box<crate::client::Error>,
+    },
 
     #[snafu(display("failed to delete orphaned resource"))]
-    DeleteOrphanedResource { source: crate::client::Error },
+    DeleteOrphanedResource {
+        #[snafu(source(from(crate::client::Error, Box::new)))]
+        source: Box<crate::client::Error>,
+    },
 }
 
 /// A cluster resource handled by [`ClusterResources`].

crates/stackable-operator/src/crd/s3/connection/v1alpha1_impl.rs

@@ -17,7 +17,8 @@ use crate::{
 pub enum ConnectionError {
     #[snafu(display("failed to retrieve S3 connection '{s3_connection}'"))]
     RetrieveS3Connection {
-        source: crate::client::Error,
+        #[snafu(source(from(crate::client::Error, Box::new)))]
+        source: Box<crate::client::Error>,
         s3_connection: String,
     },
 
@@ -37,11 +38,15 @@ pub enum ConnectionError {
     AddS3TlsClientDetailsVolumes { source: TlsClientDetailsError },
 
     #[snafu(display("failed to add required volumes"))]
-    AddVolumes { source: crate::builder::pod::Error },
+    AddVolumes {
+        #[snafu(source(from(crate::builder::pod::Error, Box::new)))]
+        source: Box<crate::builder::pod::Error>,
+    },
 
     #[snafu(display("failed to add required volumeMounts"))]
     AddVolumeMounts {
-        source: crate::builder::pod::container::Error,
+        #[snafu(source(from(crate::builder::pod::container::Error, Box::new)))]
+        source: Box<crate::builder::pod::container::Error>,
     },
 }
 

crates/stackable-operator/src/product_config_utils.rs

@@ -160,6 +160,7 @@ pub fn config_for_role_and_group<'a>(
     Ok(result)
 }
 
+#[allow(clippy::doc_overindented_list_items)]
 /// Given the configuration parameters of all `roles` partition them by `PropertyNameKind` and
 /// merge them with the role groups configuration parameters.
 ///
@@ -197,6 +198,7 @@ where
     Ok(result)
 }
 
+#[allow(clippy::doc_overindented_list_items)]
 /// Validates a product configuration for all roles and role_groups. Requires a valid product config
 /// and [`RoleConfigByPropertyKind`] which can be obtained via `transform_all_roles_to_config`.
 ///
@@ -239,6 +241,7 @@ pub fn validate_all_roles_and_groups_config(
     Ok(result)
 }
 
+#[allow(clippy::doc_overindented_list_items)]
 /// Calculates and validates a product configuration for a role and group. Requires a valid
 /// product config and existing [`RoleConfigByPropertyKind`] that can be obtained via
 /// `transform_all_roles_to_config`.
@@ -283,6 +286,7 @@ fn validate_role_and_group_config(
     Ok(result)
 }
 
+#[allow(clippy::doc_overindented_list_items)]
 /// This transforms the [`product_config::PropertyValidationResult`] back into a pure BTreeMap which can be used
 /// to set properties for config files, cli or environmental variables.
 /// Default values are ignored, Recommended and Valid values are used as is. For Warning and

crates/stackable-operator/src/product_logging/framework.rs

@@ -228,10 +228,10 @@ pub fn capture_shell_output(
 ///
 /// * `log_dir` - Directory where the log files are stored
 /// * `log_file` - Name of the active log file; When the file is rolled over then a number is
-///       appended.
+///   appended.
 /// * `max_size_in_mib` - Maximum size of all log files in MiB; This value can be slightly
-///       exceeded. The value is set to 2 if the given value is lower (1 MiB for the active log
-///       file and 1 MiB for the archived one).
+///   exceeded. The value is set to 2 if the given value is lower (1 MiB for the active log
+///   file and 1 MiB for the archived one).
 /// * `console_conversion_pattern` - Logback conversion pattern for the console appender
 /// * `config` - The logging configuration for the container
 ///
@@ -349,10 +349,10 @@ log4j.appender.FILE.layout=org.apache.log4j.xml.XMLLayout
 ///
 /// * `log_dir` - Directory where the log files are stored
 /// * `log_file` - Name of the active log file; When the file is rolled over then a number is
-///       appended.
+///   appended.
 /// * `max_size_in_mib` - Maximum size of all log files in MiB; This value can be slightly
-///       exceeded. The value is set to 2 if the given value is lower (1 MiB for the active log
-///       file and 1 MiB for the archived one).
+///   exceeded. The value is set to 2 if the given value is lower (1 MiB for the active log
+///   file and 1 MiB for the archived one).
 /// * `console_conversion_pattern` - Log4j2 conversion pattern for the console appender
 /// * `config` - The logging configuration for the container
 ///
@@ -493,15 +493,15 @@ rootLogger.appenderRef.FILE.ref = FILE"#,
 ///
 /// * `log_dir` - Directory where the log files are stored
 /// * `log_file` - Name of the active log file; When the file is rolled over then a number is
-///       appended.
+///   appended.
 /// * `max_size_in_mib` - Maximum size of all log files in MiB; This value can be slightly
-///       exceeded. The value is set to 2 if the given value is lower (1 MiB for the active log
-///       file and 1 MiB for the archived one).
+///   exceeded. The value is set to 2 if the given value is lower (1 MiB for the active log
+///   file and 1 MiB for the archived one).
 /// * `console_conversion_pattern` - Logback conversion pattern for the console appender
 /// * `config` - The logging configuration for the container
 /// * `additional_config` - Optional unstructured parameter to add special cases that are not
-///       covered in the logging configuration. Must adhere to the inner logback XML schema as
-///       shown in the example below. It is not parsed or checked and added as is to the `logback.xml`.
+///   covered in the logging configuration. Must adhere to the inner logback XML schema as
+///   shown in the example below. It is not parsed or checked and added as is to the `logback.xml`.
 ///
 /// # Example
 ///

crates/stackable-operator/src/status/condition/mod.rs

@@ -26,11 +26,11 @@ pub trait ConditionBuilder {
 /// # Arguments
 ///
 /// * `resource` - A cluster resource or status implementing [`HasStatusCondition`] in order to
-///    retrieve the "current" conditions set in the cluster. This is required to  compute
-///    condition change and set proper update / transition times.
+///   retrieve the "current" conditions set in the cluster. This is required to  compute
+///   condition change and set proper update / transition times.
 /// * `condition_builders` - A slice of structs implementing [`ConditionBuilder`]. This can be a
-///    one of the predefined ConditionBuilders like `DaemonSetConditionBuilder` or a custom
-///    implementation for special resources or different behavior.
+///   one of the predefined ConditionBuilders like `DaemonSetConditionBuilder` or a custom
+///   implementation for special resources or different behavior.
 ///
 /// # Examples
 /// ```

crates/stackable-operator/src/utils/option.rs

@@ -51,13 +51,13 @@ mod tests {
 
     #[test]
     fn as_ref_or_else() {
-        let maybe: Option<String> = None;
-        let defaulted: Cow<String> = maybe.as_ref_or_else(|| "foo".to_string());
-        assert_eq!(defaulted, Cow::<String>::Owned("foo".to_string()));
+        let maybe: Option<&str> = None;
+        let defaulted: Cow<&str> = maybe.as_ref_or_else(|| "foo");
+        assert_eq!(defaulted, Cow::<&str>::Owned("foo"));
 
-        let maybe: Option<String> = Some("foo".to_string());
-        let defaulted: Cow<String> = maybe.as_ref_or_else(|| panic!());
-        assert_eq!(defaulted, Cow::<String>::Borrowed(&"foo".to_string()));
+        let maybe: Option<&str> = Some("foo");
+        let defaulted: Cow<&str> = maybe.as_ref_or_else(|| panic!());
+        assert_eq!(defaulted, Cow::<&str>::Borrowed(&"foo"));
     }
 
     #[test]

crates/stackable-versioned-macros/src/attrs/container/k8s.rs

@@ -15,11 +15,11 @@ use crate::attrs::common::Override;
 /// - `group`: Set the group of the CR object, usually the domain of the company.
 ///   This argument is Required.
 /// - `kind`: Override the kind field of the CR object. This defaults to the struct
-///    name (without the 'Spec' suffix).
+///   name (without the 'Spec' suffix).
 /// - `singular`: Set the singular name of the CR object.
 /// - `plural`: Set the plural name of the CR object.
 /// - `namespaced`: Indicate that this is a namespaced scoped resource rather than a
-///    cluster scoped resource.
+///   cluster scoped resource.
 /// - `crates`: Override specific crates.
 /// - `status`: Set the specified struct as the status subresource.
 /// - `shortname`: Set a shortname for the CR object. This can be specified multiple

crates/stackable-versioned-macros/src/attrs/item/mod.rs

@@ -336,9 +336,9 @@ impl CommonItemAttributes {
                         downgrade_with: change.downgrade_with.as_deref().cloned(),
                         upgrade_with: change.upgrade_with.as_deref().cloned(),
                         from_ident: from_ident.clone(),
-                        from_type: from_ty.clone(),
+                        from_type: Box::new(from_ty.clone()),
                         to_ident: ident,
-                        to_type: ty,
+                        to_type: Box::new(ty),
                     },
                 );
 
@@ -354,7 +354,7 @@ impl CommonItemAttributes {
                     ItemStatus::Addition {
                         default_fn: added.default_fn.deref().clone(),
                         ident,
-                        ty,
+                        ty: Box::new(ty),
                     },
                 );
             }
@@ -387,9 +387,9 @@ impl CommonItemAttributes {
                         downgrade_with: change.downgrade_with.as_deref().cloned(),
                         upgrade_with: change.upgrade_with.as_deref().cloned(),
                         from_ident: from_ident.clone(),
-                        from_type: from_ty.clone(),
+                        from_type: Box::new(from_ty.clone()),
                         to_ident: ident,
-                        to_type: ty,
+                        to_type: Box::new(ty),
                     },
                 );
 
@@ -405,7 +405,7 @@ impl CommonItemAttributes {
                     ItemStatus::Addition {
                         default_fn: added.default_fn.deref().clone(),
                         ident,
-                        ty,
+                        ty: Box::new(ty),
                     },
                 );
             }
@@ -420,7 +420,7 @@ impl CommonItemAttributes {
                     ItemStatus::Addition {
                         default_fn: added.default_fn.deref().clone(),
                         ident: ident.deref().clone(),
-                        ty,
+                        ty: Box::new(ty),
                     },
                 );
 

crates/stackable-versioned-macros/src/codegen/changes.rs

@@ -128,7 +128,7 @@ impl ChangesetExt for BTreeMap<Version, ItemStatus> {
                         ItemStatus::NoChange {
                             previously_deprecated: false,
                             ident: previous_ident.clone(),
-                            ty: ty.clone(),
+                            ty: Box::new(ty.clone()),
                         },
                     ),
                     ItemStatus::NoChange {
@@ -151,7 +151,9 @@ impl ChangesetExt for BTreeMap<Version, ItemStatus> {
                         ItemStatus::Change {
                             to_ident, to_type, ..
                         } => (to_ident, to_type, false),
-                        ItemStatus::Deprecation { ident, .. } => (ident, ty, true),
+                        ItemStatus::Deprecation { ident, .. } => {
+                            (ident, &Box::new(ty.clone()), true)
+                        }
                         ItemStatus::NoChange {
                             previously_deprecated,
                             ident,