Skip to content

Commit b51f227

Browse files
committed
Add TODO marker
1 parent b9a16a9 commit b51f227

1 file changed

Lines changed: 9 additions & 0 deletions

File tree

  • crates/stackable-operator/src/crd/database/databases

crates/stackable-operator/src/crd/database/databases/derby.rs

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,15 @@ impl JDBCDatabaseConnection for DerbyConnection {
3030
let connection_uri = format!("jdbc:derby:{location}",);
3131
let connection_uri = connection_uri.parse().context(ParseConnectionUrlSnafu)?;
3232

33+
// TODO: Think about different drivers (depending on version)
34+
// see hive-operator:
35+
// // The driver class changed for hive 4.2.0
36+
// if ["3.1.3", "4.0.0", "4.0.1", "4.1.0"].contains(&product_version) {
37+
// "org.apache.derby.jdbc.EmbeddedDriver"
38+
// } else {
39+
// "org.apache.derby.iapi.jdbc.AutoloadedDriver"
40+
// }
41+
3342
Ok(JDBCDatabaseConnectionDetails {
3443
driver: "org.apache.derby.jdbc.ClientDriver".to_owned(),
3544
connection_uri,

0 commit comments

Comments
 (0)