Skip to content

Commit cb04eb0

Browse files
Apply suggestions from code review
Co-authored-by: Malte Sander <malte.sander.it@gmail.com>
1 parent 75efe83 commit cb04eb0

3 files changed

Lines changed: 5 additions & 5 deletions

File tree

crates/stackable-operator/src/databases/drivers/celery.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ pub trait CeleryDatabaseConnection {
1616
/// Returns the Celery connection details for the given `unique_database_name` using the
1717
/// default [`TemplatingMechanism`].
1818
///
19-
/// `unique_database_name` identifies this particular database connection within the operator
19+
/// The `unique_database_name` identifies this particular database connection within the operator
2020
/// and is used as a prefix when naming the injected environment variables. It must consist only
2121
/// of uppercase ASCII letters and underscores.
2222
fn celery_connection_details(

crates/stackable-operator/src/databases/drivers/jdbc.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ pub trait JDBCDatabaseConnection {
1616
/// Returns the JDBC connection details for the given `unique_database_name` using the
1717
/// default [`TemplatingMechanism`].
1818
///
19-
/// `unique_database_name` identifies this particular database connection within the operator
19+
/// The `unique_database_name` identifies this particular database connection within the operator
2020
/// and is used as a prefix when naming the injected environment variables. It must consist only
2121
/// of uppercase ASCII letters and underscores.
2222
fn jdbc_connection_details(
@@ -43,7 +43,7 @@ pub struct JDBCDatabaseConnectionDetails {
4343
/// The Java class name of the driver, e.g. `org.postgresql.Driver`
4444
pub driver: String,
4545

46-
/// The connection URI (without user and password), e.g.
46+
/// The connection URI (without user and password), e.g.
4747
/// `jdbc:postgresql://airflow-postgresql:5432/airflow`
4848
pub connection_uri: Url,
4949

crates/stackable-operator/src/databases/drivers/sqlalchemy.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,12 +11,12 @@ use crate::{
1111
/// [SQLAlchemy](https://www.sqlalchemy.org/) connection URLs.
1212
///
1313
/// Provides a standardized way to obtain a SQLAlchemy connection URI template together with the
14-
/// necessary credential env vars, regardless of the concrete database type.
14+
/// necessary credential environment variables, regardless of the concrete database type.
1515
pub trait SQLAlchemyDatabaseConnection {
1616
/// Returns the SQLAlchemy connection details for the given `unique_database_name` using the
1717
/// default [`TemplatingMechanism`].
1818
///
19-
/// `unique_database_name` identifies this particular database connection within the operator
19+
/// The `unique_database_name` identifies this particular database connection within the operator
2020
/// and is used as a prefix when naming the injected environment variables. It must consist only
2121
/// of uppercase ASCII letters and underscores.
2222
fn sqlalchemy_connection_details(

0 commit comments

Comments
 (0)