Skip to content

Commit e89652d

Browse files
committed
fix: correct fragment and merge macro path
1 parent c53ffca commit e89652d

2 files changed

Lines changed: 12 additions & 7 deletions

File tree

crates/stackable-operator/src/v2/builder/pod/container.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -252,7 +252,7 @@ mod tests {
252252
&EnvVarName::from_str_unsafe("ENV2"),
253253
"value2 from env_var_set2",
254254
)
255-
.with_field_path(&EnvVarName::from_str_unsafe("ENV3"), FieldPathEnvVar::Name)
255+
.with_field_path(&EnvVarName::from_str_unsafe("ENV3"), &FieldPathEnvVar::Name)
256256
.with_value(
257257
&EnvVarName::from_str_unsafe("ENV4"),
258258
"value4 from env_var_set2",
@@ -334,7 +334,7 @@ mod tests {
334334
#[test]
335335
fn test_envvarset_with_field_path() {
336336
let env_var_set = EnvVarSet::new()
337-
.with_field_path(&EnvVarName::from_str_unsafe("ENV"), FieldPathEnvVar::Name);
337+
.with_field_path(&EnvVarName::from_str_unsafe("ENV"), &FieldPathEnvVar::Name);
338338

339339
assert_eq!(
340340
Some(&EnvVar {

crates/stackable-operator/src/v2/role_utils.rs

Lines changed: 10 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ use crate::{
2323
};
2424

2525
// Variant of [`stackable_operator::role_utils::GenericCommonConfig`] that implements [`Merge`]
26-
#[derive(Clone, Debug, Default, Deserialize, JsonSchema, PartialEq, Serialize)]
26+
#[derive(Clone, Debug, Default, Deserialize, JsonSchema, Eq, PartialEq, Serialize)]
2727
pub struct GenericCommonConfig {}
2828

2929
impl Merge for GenericCommonConfig {
@@ -93,7 +93,7 @@ where
9393
role_group.config.pod_overrides.clone(),
9494
),
9595
product_specific_common_config: merged_product_specific_common_config(
96-
role.config.product_specific_common_config.clone(),
96+
&role.config.product_specific_common_config,
9797
role_group.config.product_specific_common_config.clone(),
9898
),
9999
},
@@ -138,11 +138,11 @@ fn merged_pod_overrides(
138138
merged_pod_overrides
139139
}
140140

141-
fn merged_product_specific_common_config<T>(role_config: T, role_group_config: T) -> T
141+
fn merged_product_specific_common_config<T>(role_config: &T, role_group_config: T) -> T
142142
where
143143
T: Merge,
144144
{
145-
merge(role_group_config, &role_config)
145+
merge(role_group_config, role_config)
146146
}
147147

148148
/// Type-safe names for role resources
@@ -220,7 +220,11 @@ mod tests {
220220
};
221221

222222
#[derive(Debug, Fragment, PartialEq)]
223-
#[fragment_attrs(derive(Clone, Debug, Default, Merge, PartialEq))]
223+
#[fragment(path_overrides(fragment = "crate::config::fragment"))]
224+
#[fragment_attrs(
225+
derive(Clone, Debug, Default, Merge, PartialEq),
226+
merge(path_overrides(merge = "crate::config::merge")),
227+
)]
224228
struct Config {
225229
property: String,
226230
}
@@ -242,6 +246,7 @@ mod tests {
242246
}
243247

244248
#[derive(Clone, Debug, Default, JsonSchema, Merge, PartialEq, Serialize)]
249+
#[merge(path_overrides(merge = "crate::config::merge"))]
245250
struct CommonConfig {
246251
property: Option<String>,
247252
}

0 commit comments

Comments
 (0)