Various updates (#45)

* Various updates

- Dependency updates
- Log open files limit
- Reduce logging at info slightly
- Add rust-toolchain.toml
- Fix pre-commit warnings

* Various updates

- Dep updates
- Rust toolchain update
- PR template update

* rustfmt

* Update dependencies

* Update operator-rs

* Update dependencies

* better telemetry integration

* rustfmt

* rustfmt

* use our version of cargo-udeps

* pre-commit

* pre-commit

* add markdownlint config

* add markdownlint & yamllint config

* md lint

* address review comment

Author: lfrancke

crates/containerdebug/CHANGELOG.md

@@ -7,8 +7,10 @@ All notable changes to this project will be documented in this file.
 ### Changed
 
 - Increased the default `--loop` interval from every minute to every 30 minutes ([#23]).
+- Collect and output the open files limit ([#45])
 
 [#23]: https://github.com/stackabletech/containerdebug/pull/23
+[#45]: https://github.com/stackabletech/containerdebug/pull/45
 
 ## [0.1.1] - 2024-12-16
 

crates/containerdebug/Cargo.toml

@@ -1,7 +1,7 @@
 [package]
 name = "containerdebug"
 version = "0.1.1"
-edition = "2021"
+edition = "2024"
 
 [dependencies]
 clap = { version = "4.5", features = ["derive"] }
@@ -11,9 +11,9 @@ local-ip-address = "0.6"
 serde = { version = "1.0", features = ["derive"] }
 serde_json = "1.0"
 snafu = "0.8"
-stackable-operator = { git = "https://github.com/stackabletech/operator-rs", tag = "stackable-operator-0.86.0" }
-sysinfo = { version = "0.33", features = ["serde"] }
+stackable-operator = { git = "https://github.com/stackabletech/operator-rs", tag = "stackable-operator-0.93.1", features = ["telemetry"] }
+sysinfo = { version = "0.35", features = ["serde"] }
 tracing = "0.1"
 
 [build-dependencies]
-built = { version = "0.7", features = ["chrono", "git2"] }
+built = { version = "0.8", features = ["chrono", "git2"] }

crates/containerdebug/src/main.rs

@@ -1,11 +1,12 @@
 mod error;
 mod system_information;
 
-use clap::{crate_description, crate_version, Parser};
-use stackable_operator::logging::TracingTarget;
+use clap::{Parser, crate_description, crate_version};
+use stackable_operator::telemetry::Tracing;
 use std::path::PathBuf;
 
 use crate::system_information::SystemInformation;
+use stackable_operator::telemetry::tracing::TelemetryOptions;
 use std::time::Instant;
 
 const APP_NAME: &str = "containerdebug";
@@ -27,9 +28,8 @@ struct Opts {
     #[clap(long, short = 'o')]
     output: Option<PathBuf>,
 
-    /// Tracing log collector system
-    #[arg(long, env, default_value_t, value_enum)]
-    pub tracing_target: TracingTarget,
+    #[clap(flatten)]
+    pub telemetry_arguments: TelemetryOptions,
 }
 
 mod built_info {
@@ -38,11 +38,10 @@ mod built_info {
 
 fn main() {
     let opts = Opts::parse();
-    stackable_operator::logging::initialize_logging(
-        "CONTAINERDEBUG_LOG",
-        APP_NAME,
-        opts.tracing_target,
-    );
+
+    let _trace_guard = Tracing::pre_configured(APP_NAME, opts.telemetry_arguments)
+        .init()
+        .unwrap();
 
     // Wrap *all* output in a span, to separate it from main app output.
     let _span = tracing::error_span!("containerdebug").entered();

crates/containerdebug/src/system_information/mod.rs

@@ -42,7 +42,7 @@ impl SystemInformation {
     /// Collects static information that doesn't need to be refreshed.
     #[tracing::instrument(name = "SystemInformation::init")]
     pub fn init() -> CollectContext {
-        tracing::info!("initializing");
+        tracing::debug!("initializing");
         let mut ctx = CollectContext {
             // Each module is responsible for updating the information that it cares about.
             system: sysinfo::System::new(),
@@ -53,14 +53,14 @@ impl SystemInformation {
                 "failed to initialize user module, ignoring but this will likely cause collection errors..."
             );
         }
-        tracing::info!("init finished");
+        tracing::debug!("init finished");
         ctx
     }
 
     /// Collects and reports
     #[tracing::instrument(name = "SystemInformation::collect", skip(ctx))]
     pub fn collect(ctx: &mut CollectContext) -> Self {
-        tracing::info!("Starting data collection");
+        tracing::debug!("Starting data collection");
 
         let info = Self {
             resources: Some(resources::Resources::collect(&mut ctx.system)),
@@ -74,7 +74,7 @@ impl SystemInformation {
             // ..Default::default()
         };
 
-        tracing::info!("Data collection finished");
+        tracing::debug!("Data collection finished");
         info
     }
 }

crates/containerdebug/src/system_information/network.rs

@@ -1,4 +1,4 @@
-use hickory_resolver::{system_conf::read_system_conf, Resolver};
+use hickory_resolver::{Resolver, system_conf::read_system_conf};
 use local_ip_address::list_afinet_netifas;
 use serde::Serialize;
 use std::{

crates/containerdebug/src/system_information/resources.rs

@@ -6,6 +6,8 @@ pub struct Resources {
     pub cpu_count: usize,
     pub physical_core_count: Option<usize>,
 
+    pub open_files_limit: Option<usize>,
+
     pub total_memory: u64,
     pub free_memory: u64,
     pub available_memory: u64,
@@ -33,13 +35,16 @@ impl Resources {
         );
 
         let cpu_count = sys.cpus().len();
-        let physical_core_count = sys.physical_core_count();
+        let physical_core_count = System::physical_core_count();
         tracing::info!(
             cpus.physical = cpu_count,
             cpus.cores.physical = physical_core_count,
             "cpus"
         );
 
+        let open_files_limit = System::open_files_limit();
+        tracing::info!(open_files.limit = open_files_limit, "open files limit");
+
         let total_memory = sys.total_memory();
         let free_memory = sys.free_memory();
         let available_memory = sys.available_memory();
@@ -85,6 +90,8 @@ impl Resources {
             cpu_count,
             physical_core_count,
 
+            open_files_limit,
+
             total_memory,
             free_memory,
             available_memory,