Skip to content

Commit fc4197e

Browse files
Apply suggestions from code review
Co-authored-by: Techassi <git@techassi.dev>
1 parent 05660fa commit fc4197e

1 file changed

Lines changed: 6 additions & 6 deletions

File tree

crates/stackable-operator/src/v2/builder/pod/container.rs

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -190,7 +190,11 @@ impl<'a> From<&'a EnvVarSet> for Vec<&'a EnvVar> {
190190
value.into_iter().collect()
191191
}
192192
}
193-
193+
impl From<EnvVarSet> for Vec<EnvVar> {
194+
fn from(value: EnvVarSet) -> Self {
195+
value.into_iter().collect()
196+
}
197+
}
194198
impl<'a> IntoIterator for &'a EnvVarSet {
195199
type IntoIter = vec::IntoIter<Self::Item>;
196200
type Item = &'a EnvVar;
@@ -211,11 +215,7 @@ impl IntoIterator for EnvVarSet {
211215
type Item = EnvVar;
212216

213217
fn into_iter(self) -> Self::IntoIter {
214-
Vec::from(&self)
215-
.into_iter()
216-
.cloned()
217-
.collect::<Vec<_>>()
218-
.into_iter()
218+
Vec::from(self).into_iter()
219219
}
220220
}
221221

0 commit comments

Comments
 (0)