refactor: Switch ObjectOverrides to unit struct

Author: sbernauer

crates/stackable-operator/src/deep_merger/crd.rs

@@ -6,20 +6,20 @@ use serde::{Deserialize, Serialize, de::DeserializeOwned};
 use super::apply_deep_merge;
 use crate::utils::crds::raw_object_list_schema;
 
-#[derive(Clone, Debug, Deserialize, JsonSchema, Serialize, PartialEq)]
-#[serde(rename_all = "camelCase")]
-pub struct ObjectOverrides {
+#[derive(Clone, Debug, Deserialize, Default, JsonSchema, Serialize, PartialEq)]
+pub struct ObjectOverrides(
     /// A list of generic Kubernetes objects, which are merged on the objects that the operator
     /// creates.
     ///
     /// List entries are arbitrary YAML objects, which need to be valid Kubernetes objects.
     ///
     /// Read the [Object overrides documentation](DOCS_BASE_URL_PLACEHOLDER/concepts/overrides#object-overrides)
     /// for more information.
-    #[serde(default)]
+    //
+    // Remember to use `#[serde(default)]` when including this into a CRD!
     #[schemars(schema_with = "raw_object_list_schema")]
-    pub object_overrides: Vec<DynamicObject>,
-}
+    Vec<DynamicObject>,
+);
 
 impl ObjectOverrides {
     /// Takes an arbitrary Kubernetes object (`base`) and applies the configured list of deep merges
@@ -31,7 +31,7 @@ impl ObjectOverrides {
     where
         R: kube::Resource<DynamicType = ()> + DeepMerge + DeserializeOwned,
     {
-        for object_override in &self.object_overrides {
+        for object_override in &self.0 {
             apply_deep_merge(base, object_override)?;
         }
         Ok(())

crates/xtask/src/crd/dummy.rs

@@ -49,7 +49,7 @@ pub mod versioned {
         secret_reference: stackable_operator::shared::secret::SecretReference,
         tls_client_details: stackable_operator::commons::tls_verification::TlsClientDetails,
 
-        #[serde(flatten)]
+        #[serde(default)]
         pub object_overrides: ObjectOverrides,
 
         // Already versioned