chore: Bump Rust edition to 2024 (#710)

* chore: bump Rust edition to 2024 and update dependencies + clippy refactors

Upgrade workspace and crates to Rust 2024 edition and apply tool-driven fixes:

- Bump Rust edition from 2021 to 2024 across workspace crates (Cargo.toml, Cargo.nix)
- Update `rustls-webpki` dependency to 0.103.13
- Apply `cargo fix --edition` changes
  - Add `use<>` lifetime capture in `impl Trait` return types for iterators
- Apply Clippy suggestions and minor refactors
  - Simplify iterator-returning functions with correct lifetime capture syntax
  - Refactor `trystream_any` to fix warning

* fix(krb5-provision-keytab): disambiguate into_future in CredentialCache

Explicitly selecting TryFutureExt::into_future

* Refactor: Ignore clippy, reverting loop and update git2 due to advisory

* Fix: Update anyhow to address RustSec advisories, reverting p12 to 2021 and ignore cargo warning

---------

Co-authored-by: Sebastian Bernauer <sebastian.bernauer@stackable.de>

Author: Saul-STFC

Cargo.lock

@@ -7,7 +7,7 @@ resolver = "2"
 version = "0.0.0-dev"
 authors = ["Stackable GmbH <info@stackable.tech>"]
 license = "OSL-3.0"
-edition = "2021"
+edition = "2024"
 repository = "https://github.com/stackabletech/secret-operator"
 
 [workspace.dependencies]

Cargo.nix

@@ -94,10 +94,9 @@ impl CredentialCache {
                 .expect("key was just confirmed to exist in cache")))
         } else {
             tracing::info!("credential not found in cache, generating...");
-            match mk_value(Ctx {
+            match TryFutureExt::into_future(mk_value(Ctx {
                 cache_ref: self.cache_ref.clone(),
-            })
-            .into_future()
+            }))
             .await
             {
                 Ok(value) => {

Cargo.toml

@@ -20,7 +20,7 @@ impl SecretClassBackend {
     pub fn refers_to_config_map(
         &self,
         config_map: &PartialObjectMeta<ConfigMap>,
-    ) -> impl Iterator<Item = SearchNamespaceMatchCondition> {
+    ) -> impl Iterator<Item = SearchNamespaceMatchCondition> + use<> {
         let cm_namespace = config_map.metadata.namespace.as_deref();
         match self {
             Self::K8sSearch(backend) => {
@@ -40,7 +40,7 @@ impl SecretClassBackend {
     pub fn refers_to_secret(
         &self,
         secret: &PartialObjectMeta<Secret>,
-    ) -> impl Iterator<Item = SearchNamespaceMatchCondition> {
+    ) -> impl Iterator<Item = SearchNamespaceMatchCondition> + use<> {
         match self {
             Self::AutoTls(backend) => {
                 (backend.ca.secret == *secret).then_some(SearchNamespaceMatchCondition::True)

rust/krb5-provision-keytab/src/credential_cache.rs

@@ -26,7 +26,7 @@ impl SecretClassBackend {
     pub fn refers_to_config_map(
         &self,
         config_map: &PartialObjectMeta<ConfigMap>,
-    ) -> impl Iterator<Item = SearchNamespaceMatchCondition> {
+    ) -> impl Iterator<Item = SearchNamespaceMatchCondition> + use<> {
         let cm_namespace = config_map.metadata.namespace.as_deref();
         match self {
             Self::K8sSearch(backend) => {
@@ -46,7 +46,7 @@ impl SecretClassBackend {
     pub fn refers_to_secret(
         &self,
         secret: &PartialObjectMeta<Secret>,
-    ) -> impl Iterator<Item = SearchNamespaceMatchCondition> {
+    ) -> impl Iterator<Item = SearchNamespaceMatchCondition> + use<> {
         match self {
             Self::AutoTls(backend) => {
                 (backend.ca.secret == *secret).then_some(SearchNamespaceMatchCondition::True)

rust/operator-binary/src/crd/secret_class/v1alpha1_impl.rs

@@ -121,6 +121,7 @@ pub fn error_full_message(err: &dyn std::error::Error) -> String {
 }
 
 /// Propagates `Ok(true)` and `Err(_)` from `stream`, otherwise returns `Ok(false)`.
+#[allow(tail_expr_drop_order)]
 pub async fn trystream_any<S: Stream<Item = Result<bool, E>>, E>(stream: S) -> Result<bool, E> {
     pin_mut!(stream);
     while let Some(value) = stream.next().await {

rust/operator-binary/src/crd/secret_class/v1alpha2_impl.rs

@@ -635,7 +635,7 @@ fn pbepkcs12sha1core(d: &[u8], i: &[u8], a: &mut Vec<u8>, iterations: u64) -> Ve
     a.append(&mut ai.clone());
     ai
 }
-
+#[allow(clippy::manual_div_ceil)] // This is a fork, ignoring errors
 #[allow(clippy::many_single_char_names)]
 fn pbepkcs12sha1(pass: &[u8], salt: &[u8], iterations: u64, id: u8, size: u64) -> Vec<u8> {
     const U: u64 = 160 / 8;