Add some doc comments

Author: sbernauer

rust/truststore-merger/src/parsers.rs

@@ -42,6 +42,7 @@ pub fn parse_pem_contents(pem_bytes: &[u8]) -> anyhow::Result<Vec<X509>> {
 ///
 /// So I ditched that effort and we are now shelling out to the CLI. Sorry!
 /// The proper solution would be that secret-operator writes PKCS12 truststores using modern algorithms.
+/// For that we probably(?) drop the p12 crate?
 #[allow(unused)]
 pub fn parse_pkcs12_file(file_contents: &[u8], password: &str) -> anyhow::Result<Vec<X509>> {
     let parsed = Pkcs12::from_der(file_contents)

rust/utils/src/pkcs12.rs

@@ -32,6 +32,7 @@ pub fn pkcs12_truststore<'a>(
     // OpenSSL's current master branch contains the `PKCS12_create_ex2` function
     // (https://www.openssl.org/docs/manmaster/man3/PKCS12_create_ex.html), but it is not currently in
     // OpenSSL 3.1 (as of 3.1.1), and it is not wrapped by rust-openssl.
+    // See https://github.com/sfackler/rust-openssl/blob/d21f42333698edeebd7327a4e25412b191757e31/openssl/src/pkcs12.rs#L225
 
     // Required for Java to trust the certificate, from
     // https://github.com/openjdk/jdk/blob/990e3a700dce3441bd9506ca571c1790e57849a9/src/java.base/share/classes/sun/security/util/KnownOIDs.java#L414-L415