chore: Fix clippy lints

Author: sbernauer

rust/operator-binary/src/backend/cert_manager.rs

@@ -70,7 +70,7 @@ pub enum Error {
 impl SecretBackendError for Error {
     fn grpc_code(&self) -> tonic::Code {
         match self {
-            Error::NoPvcName { .. } => tonic::Code::FailedPrecondition,
+            Error::NoPvcName => tonic::Code::FailedPrecondition,
             Error::ScopeAddresses { .. } => tonic::Code::Unavailable,
             Error::GetSecret { .. } => tonic::Code::Unavailable,
             Error::GetCertManagerCertificate { .. } => tonic::Code::Unavailable,

rust/operator-binary/src/backend/dynamic.rs

@@ -190,7 +190,8 @@ pub enum FromSelectorError {
 
     #[snafu(display("failed to initialize backend for {class}"))]
     FromClass {
-        source: FromClassError,
+        #[snafu(source(from(FromClassError, Box::new)))]
+        source: Box<FromClassError>,
         class: ObjectRef<SecretClass>,
     },
 }

rust/operator-binary/src/backend/tls/ca.rs

@@ -133,7 +133,7 @@ impl SecretBackendError for Error {
             Error::BuildCertificate { .. } => tonic::Code::FailedPrecondition,
             Error::SerializeCertificate { .. } => tonic::Code::FailedPrecondition,
             Error::SaveCaCertificate { .. } => tonic::Code::Unavailable,
-            Error::SaveRequestedButForbidden { .. } => tonic::Code::FailedPrecondition,
+            Error::SaveRequestedButForbidden => tonic::Code::FailedPrecondition,
         }
     }
 

rust/operator-binary/src/grpc.rs

@@ -6,6 +6,8 @@
 pub static FILE_DESCRIPTOR_SET_BYTES: &[u8] =
     include_bytes!(concat!(env!("OUT_DIR"), "/file_descriptor_set.bin"));
 
+// The prost-generated code breaks many clippy lints. Just disable them since there's nothing we can do about it.
+#[allow(clippy::all)]
 pub mod csi {
     pub mod v1 {
         tonic::include_proto!("csi.v1");

rust/operator-binary/src/main.rs

@@ -1,3 +1,7 @@
+// TODO: Look into how to properly resolve `clippy::result_large_err`.
+// This will need changes in our and upstream error types.
+#![allow(clippy::result_large_err)]
+
 use std::{os::unix::prelude::FileTypeExt, path::PathBuf, pin::pin};
 
 use anyhow::Context;