review: Bounded Default impl + simplified call site

Author: dervoeti

rust/operator-binary/src/format/convert.rs

@@ -22,10 +22,7 @@ pub fn convert(
         (WellKnownSecretData::TlsPem(pem), SecretFormat::TlsPkcs12) => {
             Ok(WellKnownSecretData::TlsPkcs12(convert_tls_to_pkcs12(
                 pem,
-                compat
-                    .tls_pkcs12_password
-                    .as_deref()
-                    .map_or("", String::as_str),
+                &compat.tls_pkcs12_password.unwrap_or_default(),
             )?))
         }
 

rust/operator-binary/src/utils.rs

@@ -179,9 +179,17 @@ pub fn asn1time_to_offsetdatetime(asn: &Asn1TimeRef) -> Result<OffsetDateTime, A
 
 /// Wrapper for (mostly) secret values that should not be logged.
 // When/if migrating to Valuable, provide a dummy implementation of Value too
-#[derive(Default)]
 pub struct Unloggable<T>(pub T);
 
+impl<T> Default for Unloggable<T>
+where
+    T: Default,
+{
+    fn default() -> Self {
+        Self(T::default())
+    }
+}
+
 impl<T> Debug for Unloggable<T> {
     fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {
         f.write_str("<redacted>")