Skip to content

Commit 744fd18

Browse files
committed
docs: consolidate upstream / v2 comments
1 parent 71d04c5 commit 744fd18

2 files changed

Lines changed: 3 additions & 4 deletions

File tree

rust/operator-binary/src/connect/crd.rs

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -320,9 +320,8 @@ impl v1alpha1::ServerConfig {
320320
}
321321
}
322322

323-
// This is the equivalent to merged_config() in other ops
324-
// only here we only need to merge operator defaults with
325-
// user configuration.
323+
// Merges the operator defaults with the user-provided configuration to produce the resolved
324+
// server and executor configs.
326325
impl v1alpha1::SparkConnectServer {
327326
pub fn server_config(&self) -> Result<v1alpha1::ServerConfig, Error> {
328327
let defaults = v1alpha1::ServerConfig::default_config();

rust/operator-binary/src/product_logging/mod.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ const CONSOLE_CONVERSION_PATTERN: &str = "%d{ISO8601} %p [%t] %c - %m%n";
1717
/// The static Vector agent configuration (`vector.yaml`).
1818
///
1919
/// Cluster/role/role-group/namespace metadata and the file-log level are injected at runtime via
20-
/// the env vars set by the v2 `vector_container` (`${CLUSTER_NAME}`, `${ROLE_NAME}`,
20+
/// the env vars set on the Vector sidecar container (`${CLUSTER_NAME}`, `${ROLE_NAME}`,
2121
/// `${ROLE_GROUP_NAME}`, `${NAMESPACE}`, `${VECTOR_FILE_LOG_LEVEL}`, `${VECTOR_AGGREGATOR_ADDRESS}`,
2222
/// …), so this file is role-group-agnostic.
2323
const VECTOR_CONFIG: &str = include_str!("vector.yaml");

0 commit comments

Comments
 (0)