Apply suggestions from code review

Co-authored-by: Sebastian Bernauer <sebastian.bernauer@stackable.de>

Author: adwk67

docs/modules/superset/pages/getting_started/first_steps.adoc

@@ -16,7 +16,7 @@ Refer to the xref:required-external-components[supported databases] for producti
 
 == Secret with Superset credentials
 
-You need to create secrets with the required credentials (an admin account for Superset and database connection credentials).
+You need to create two Secrets with the required credentials (an admin account for Superset as well as database connection credentials).
 Create a file called `superset-credentials.yaml`:
 
 [source,yaml]
@@ -48,7 +48,7 @@ include::example$getting_started/getting_started.sh[tag=apply-superset-cluster]
 
 `metadata.name` contains the name of the Superset cluster.
 
-The previously created credentials secret must be referenced in `spec.clusterConfig.credentialsSecretName`, and the database connection is configured via `spec.clusterConfig.metadataDatabase`.
+The previously created credentials Secret must be referenced in `spec.clusterConfig.credentialsSecretName`, and the database connection Secret is configured via `spec.clusterConfig.metadataDatabase`.
 
 The `rowLimit` configuration option defines the row limit when requesting chart data.
 

docs/modules/superset/pages/usage-guide/database-connections.adoc

@@ -17,11 +17,11 @@ spec:
         credentialsSecretName: superset-postgresql-credentials # <2>
 ----
 <1> A reference to one of the supported database backends (e.g. `postgresql`).
-<2> A reference to a Secret which must contain the two fields `username` and `password`.
+<2> A reference to a Secret which must contain the two keys `username` and `password`.
 
 == Generic connections
 
-Alternatively, these connections can also be defined in full in a referenced secret:
+Alternatively, these connections can also be defined in full in a referenced Secret:
 
 [source,yaml]
 ----
@@ -32,4 +32,4 @@ spec:
         connectionUrlSecretName: superset-metadata # <1>
 ----
 
-<1> A reference to a secret which must contain the single field `connectionUrl` e.g. `postgresql://superset:superset@superset-postgresql/superset`
+<1> A reference to a Secret which must contain the single key `connectionUrl` e.g. `postgresql://superset:superset@superset-postgresql/superset`

rust/operator-binary/src/druid_connection_controller.rs

@@ -331,7 +331,7 @@ async fn build_import_job(
     ));
 
     // "METADATA" is the prefix for the env vars that hold the database credentials
-    // (e.g. METADATA_DATABASE_USERNAME, METADATA_DATABASE_PASSWORD). It must match
+    // (e.g. METADATA_DATABASE_USERNAME, METADATA_DATABASE_PASSWORD). It should match
     // the prefix used by the airflow-operator for consistency.
     let templating_mechanism = TemplatingMechanism::BashEnvSubstitution;
     let metadata_database_connection_details = superset_cluster

rust/operator-binary/src/superset_controller.rs

@@ -719,7 +719,7 @@ fn build_server_rolegroup_statefulset(
         .service_account_name(sa_name);
 
     // "METADATA" is the prefix for the env vars that hold the database credentials
-    // (e.g. METADATA_DATABASE_USERNAME, METADATA_DATABASE_PASSWORD). It must match
+    // (e.g. METADATA_DATABASE_USERNAME, METADATA_DATABASE_PASSWORD). It should match
     // the prefix used by the airflow-operator for consistency.
     let templating_mechanism = TemplatingMechanism::BashEnvSubstitution;
     let metadata_database_connection_details = superset