Skip to content

Commit 6c93c4b

Browse files
xeniapesbernauer
andauthored
chore!: Rename EXPERIMENTAL_FILE_HEADER / EXPERIMENTAL_FILE_FOOTER in superset_config.py (#721)
* chore: Rename EXPERIMENTAL_FILE_HEADER / EXPERIMENTAL_FILE_FOOTER in webserver_config.py * adjust changelog entry * Update CHANGELOG.md Co-authored-by: Sebastian Bernauer <sebastian.bernauer@stackable.de> --------- Co-authored-by: Sebastian Bernauer <sebastian.bernauer@stackable.de>
1 parent 9d66516 commit 6c93c4b

4 files changed

Lines changed: 12 additions & 10 deletions

File tree

CHANGELOG.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,9 +8,11 @@
88
- BREAKING: `configOverrides` now only accepts the supported config file name `superset_config.py`. Previously arbitrary keys were silently accepted but ignored ([#719]).
99
- Bump `stackable-operator` to 0.110.0 and `kube` to 3.1.0 ([#719]).
1010
- Support setting `clientAuthenticationMethod` for OIDC authentication. The value is passed through to the Flask-AppBuilder config as `token_endpoint_auth_method` ([#719]).
11+
- BREAKING: Rename `EXPERIMENTAL_FILE_HEADER` and `EXPERIMENTAL_FILE_FOOTER` in `superset_config.py` for arbitrary Python code to `FILE_HEADER` and `FILE_FOOTER` ([#719], [#721]).
1112

1213
[#717]: https://github.com/stackabletech/superset-operator/pull/717
1314
[#719]: https://github.com/stackabletech/superset-operator/pull/719
15+
[#721]: https://github.com/stackabletech/superset-operator/pull/721
1416

1517
## [26.3.0] - 2026-03-16
1618

docs/modules/superset/pages/usage-guide/configuration-environment-overrides.adoc

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,7 @@ For a full list of configuration options we refer to the
5959
https://github.com/apache/superset/blob/master/superset/config.py[main config file for Superset].
6060

6161
As Superset can be configured with python code too, arbitrary code can be added to the `superset_conf.py`.
62-
You can use either `EXPERIMENTAL_FILE_HEADER` to add code to the top or `EXPERIMENTAL_FILE_FOOTER` to add to the bottom.
62+
You can use either `FILE_HEADER` to add code to the top or `FILE_FOOTER` to add to the bottom.
6363

6464
IMPORTANT: This is an experimental feature
6565

@@ -69,9 +69,9 @@ nodes:
6969
configOverrides:
7070
superset_config.py:
7171
CSV_EXPORT: "{'encoding': 'utf-8'}"
72-
EXPERIMENTAL_FILE_HEADER: |
72+
FILE_HEADER: |
7373
from modules.my_module import my_class
74-
EXPERIMENTAL_FILE_FOOTER: |
74+
FILE_FOOTER: |
7575
import logging
7676
from superset.security import SupersetSecurityManager
7777

tests/templates/kuttl/smoke/30-install-superset.yaml.j2

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -46,17 +46,17 @@ spec:
4646
enableVectorAgent: {{ lookup('env', 'VECTOR_AGGREGATOR') | length > 0 }}
4747
configOverrides:
4848
superset_config.py:
49-
EXPERIMENTAL_FILE_HEADER: |
49+
FILE_HEADER: |
5050
COMMON_HEADER_VAR = "role-value"
5151
ROLE_HEADER_VAR = "role-value"
52-
EXPERIMENTAL_FILE_FOOTER: |
52+
FILE_FOOTER: |
5353
ROLE_FOOTER_VAR = "role-value"
5454
roleGroups:
5555
default:
5656
replicas: 1
5757
configOverrides:
5858
superset_config.py:
59-
EXPERIMENTAL_FILE_HEADER: |
59+
FILE_HEADER: |
6060
COMMON_HEADER_VAR = "group-value"
6161
envOverrides:
6262
COMMON_VAR: group-value # overrides role value

tests/templates/kuttl/smoke/31-assert.yaml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
---
22
apiVersion: kuttl.dev/v1beta1
33
kind: TestAssert
4-
timeout: 600
4+
timeout: 300
55
commands:
66
#
77
# Test envOverrides
@@ -16,9 +16,9 @@ commands:
1616
)
1717
1818
# Config Test Assertions
19-
echo "$SUPERSET_CONFIG" | grep 'COMMON_HEADER_VAR = "group-value"'
20-
echo "$SUPERSET_CONFIG" | grep 'ROLE_FOOTER_VAR = "role-value"'
21-
echo "$SUPERSET_CONFIG" | grep -v 'ROLE_HEADER_VAR = "role-value"'
19+
echo "$SUPERSET_CONFIG" | grep '^COMMON_HEADER_VAR = "group-value"'
20+
echo "$SUPERSET_CONFIG" | grep '^ROLE_FOOTER_VAR = "role-value"'
21+
echo "$SUPERSET_CONFIG" | grep -v '^ROLE_HEADER_VAR = "role-value"'
2222
2323
# STS Spec Test Data
2424
SUPERSET_NODE_DEFAULT_STS=$(kubectl -n "$NAMESPACE" get sts superset-node-default -o yaml)

0 commit comments

Comments
 (0)