Skip to content

Commit 84d1a00

Browse files
committed
Remove left over stopped flag (#353)
# Description Co-authored-by: Malte Sander <malte.sander.it@gmail.com>
1 parent 7a7ddec commit 84d1a00

3 files changed

Lines changed: 1 addition & 12 deletions

File tree

deploy/helm/superset-operator/crds/crds.yaml

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1503,10 +1503,6 @@ spec:
15031503
required:
15041504
- roleGroups
15051505
type: object
1506-
stopped:
1507-
description: Emergency stop button, if `true` then all pods are stopped without affecting configuration (as setting `replicas` to `0` would)
1508-
nullable: true
1509-
type: boolean
15101506
vectorAggregatorConfigMapName:
15111507
description: Name of the Vector aggregator discovery ConfigMap. It must contain the key `ADDRESS` with the address of the Vector aggregator.
15121508
nullable: true

rust/crd/src/lib.rs

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -142,9 +142,6 @@ pub const HTTP_PORT: &str = "http";
142142
)]
143143
#[serde(rename_all = "camelCase")]
144144
pub struct SupersetClusterSpec {
145-
/// Emergency stop button, if `true` then all pods are stopped without affecting configuration (as setting `replicas` to `0` would)
146-
#[serde(default, skip_serializing_if = "Option::is_none")]
147-
pub stopped: Option<bool>,
148145
/// The Superset image to use
149146
pub image: ProductImage,
150147
/// Superset cluster configuration options.

rust/operator-binary/src/superset_controller.rs

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -685,11 +685,7 @@ fn build_server_rolegroup_statefulset(
685685
.build(),
686686
spec: Some(StatefulSetSpec {
687687
pod_management_policy: Some("Parallel".to_string()),
688-
replicas: if superset.spec.stopped.unwrap_or(false) {
689-
Some(0)
690-
} else {
691-
rolegroup.and_then(|rg| rg.replicas).map(i32::from)
692-
},
688+
replicas: rolegroup.and_then(|rg| rg.replicas).map(i32::from),
693689
selector: LabelSelector {
694690
match_labels: Some(role_group_selector_labels(
695691
superset,

0 commit comments

Comments
 (0)