added role/From impl for superset roles plus parsing test

Author: adwk67

rust/operator-binary/src/controller.rs

@@ -235,7 +235,7 @@ impl ValidatedCluster {
     ) -> ResourceNames {
         ResourceNames {
             cluster_name: self.name.clone(),
-            role_name: role.role_name(),
+            role_name: role.into(),
             role_group_name: role_group_name.clone(),
         }
     }
@@ -254,7 +254,7 @@ impl ValidatedCluster {
         role: &SupersetRole,
         role_group_name: &RoleGroupName,
     ) -> Labels {
-        self.recommended_labels_for(&role.role_name(), role_group_name)
+        self.recommended_labels_for(&role.into(), role_group_name)
     }
 
     pub fn recommended_labels_for(
@@ -274,7 +274,7 @@ impl ValidatedCluster {
     ) -> Labels {
         self.recommended_labels_with(
             &build::UNVERSIONED_PRODUCT_VERSION,
-            &role.role_name(),
+            &role.into(),
             role_group_name,
         )
     }
@@ -301,7 +301,7 @@ impl ValidatedCluster {
         role: &SupersetRole,
         role_group_name: &RoleGroupName,
     ) -> Labels {
-        role_group_selector(self, &product_name(), &role.role_name(), role_group_name)
+        role_group_selector(self, &product_name(), &role.into(), role_group_name)
     }
 
     /// Returns an [`ObjectMetaBuilder`] pre-filled with the namespace, an owner reference back to

rust/operator-binary/src/controller/build/resource/pdb.rs

@@ -25,7 +25,7 @@ pub fn build_pdb(
     let pdb = pod_disruption_budget_builder_with_role(
         validated,
         &product_name(),
-        &role.role_name(),
+        &role.into(),
         &operator_name(),
         &controller_name(),
     )

rust/operator-binary/src/crd/mod.rs

@@ -30,6 +30,7 @@ use stackable_operator::{
         types::{
             common::Port,
             kubernetes::{ConfigMapName, ContainerName, ListenerClassName},
+            operator::RoleName,
         },
     },
     versioned::versioned,
@@ -417,11 +418,23 @@ impl SupersetRole {
             Self::Worker | Self::Beat => None,
         }
     }
+}
+
+impl From<SupersetRole> for RoleName {
+    fn from(value: SupersetRole) -> Self {
+        value
+            .to_string()
+            .parse()
+            .expect("a SupersetRole serialises to a valid RoleName")
+    }
+}
 
-    pub fn role_name(&self) -> stackable_operator::v2::types::operator::RoleName {
-        self.to_string()
+impl From<&SupersetRole> for RoleName {
+    fn from(value: &SupersetRole) -> Self {
+        value
+            .to_string()
             .parse()
-            .expect("a Superset serialises to a valid RoleName")
+            .expect("a SupersetRole serialises to a valid RoleName")
     }
 }
 
@@ -603,17 +616,20 @@ impl v1alpha1::SupersetCluster {
 
 #[cfg(test)]
 mod tests {
-    use stackable_operator::versioned::test_utils::RoundtripTestData;
+    use stackable_operator::{
+        v2::types::operator::RoleName, versioned::test_utils::RoundtripTestData,
+    };
     use strum::IntoEnumIterator;
 
     use super::{SupersetRole, v1alpha1};
 
-    /// Locks the invariant behind the `expect` in [`SupersetRole::role_name`]: every
-    /// `SupersetRole` variant (present and future) must serialise to a valid `RoleName`.
+    /// Locks the invariant behind the `expect` in the `From<SupersetRole> for RoleName` impls:
+    /// every `SupersetRole` variant (present and future) must serialise to a valid `RoleName`.
     #[test]
     fn every_superset_role_serialises_to_a_valid_role_name() {
         for role in SupersetRole::iter() {
-            role.role_name();
+            let _: RoleName = (&role).into();
+            let _: RoleName = role.into();
         }
     }