Skip to content

chore: Listener class at node role level only - #643

Merged
adwk67 merged 5 commits into
mainfrom
feat/role-level-listener
Jun 24, 2025
Merged

chore: Listener class at node role level only#643
adwk67 merged 5 commits into
mainfrom
feat/role-level-listener

Conversation

@adwk67

@adwk67 adwk67 commented Jun 24, 2025

Copy link
Copy Markdown
Member

Description

🟢 Openshift

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author

  • Changes are OpenShift compatible
  • CRD changes approved
  • CRD documentation for all fields, following the style guide.
  • Helm chart can be installed and deployed operator works
  • Integration tests passed (for non trivial changes)
  • Changes need to be "offline" compatible
  • Links to generated (nightly) docs added
  • Release note snippet added

Reviewer

  • Code contains useful comments
  • Code contains useful logging statements
  • (Integration-)Test cases added
  • Documentation added or updated. Follows the style guide.
  • Changelog updated
  • Cargo.toml only contains references to git tags (not specific commits or branches)

Acceptance

  • Feature Tracker has been updated
  • Proper release label has been added
  • Links to generated (nightly) docs added
  • Release note snippet added
  • Add type/deprecation label & add to the deprecation schedule
  • Add type/experimental label & add to the experimental features tracker

@adwk67 adwk67 changed the title chore: Listener class at webserver role level only chore: Listener class at node role level only Jun 24, 2025
@adwk67 adwk67 self-assigned this Jun 24, 2025
@adwk67 adwk67 moved this to Development: Waiting for Review in Stackable Engineering Jun 24, 2025
@maltesander
maltesander self-requested a review June 24, 2025 14:18
@maltesander maltesander moved this from Development: Waiting for Review to Development: In Review in Stackable Engineering Jun 24, 2025
Comment thread rust/operator-binary/src/superset_controller.rs Outdated
Comment thread tests/templates/kuttl/external-access/30-assert.yaml

@maltesander maltesander left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some clusterConfig.listenerClass references e.g. docs/modules/superset/examples/getting_started/superset.yaml and docs docs/modules/superset/pages/usage-guide/listenerclass.adoc (and a couple more)

Comment thread rust/operator-binary/src/superset_controller.rs Outdated

@maltesander maltesander left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@adwk67
adwk67 enabled auto-merge June 24, 2025 15:38
@adwk67
adwk67 added this pull request to the merge queue Jun 24, 2025
Merged via the queue into main with commit c8d527e Jun 24, 2025
17 checks passed
@adwk67
adwk67 deleted the feat/role-level-listener branch June 24, 2025 15:53
@adwk67 adwk67 moved this from Development: In Review to Development: Done in Stackable Engineering Jun 24, 2025
@lfrancke lfrancke moved this from Development: Done to Done in Stackable Engineering Jun 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants