You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Copy file name to clipboardExpand all lines: docs/proxy-modes.md
+10-10Lines changed: 10 additions & 10 deletions
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -16,34 +16,34 @@ In this mode, the client will make all requests through trino-lb, not only the i
16
16
17
17
Benefits:
18
18
19
-
* Counting queries can be achieved by "sniffing" the traffic
20
-
* Trino clients don't need network access to coordinator
19
+
-Counting queries can be achieved by inspecting the traffic
20
+
-Trino clients do not require network access to coordinator
21
21
22
22
Downsides:
23
23
24
-
* Query runtimes can be increased in case many data is transferred from the Trino coordinator to the Trino client due to network delay added by trino-lb (have a look at [a performance research task](https://github.com/stackabletech/trino-lb/issues/72) for details)
24
+
-Query run times can be increased in when a lot of data is transferred from the Trino coordinator to the Trino client due to network delay added by trino-lb (see the [performance research task](https://github.com/stackabletech/trino-lb/issues/72) for details)
25
25
26
26
## Proxy first call
27
27
28
-
Only the initial `POST` is proxied, all following requests will be send to the Trino cluster directly.
28
+
In this mode, the client only sends the initial `POST` to trino-lb. All following requests will be send to the Trino cluster directly.
29
29
30
30
As trino-lb can not "sniff" the traffic to get informed about started and finished queries we need to hook it up as [HTTP event listener](https://trino.io/docs/current/admin/event-listeners-http.html) in Trino.
31
31
This way trino-lb will get informed about all query starts and completions.
32
32
33
33
Benefits:
34
34
35
-
* Better performance, as there is no network delay added by trino-lb
36
-
* In the future more advanced features can be build based on information from the Trino events
35
+
-Better performance, as there is no network delay added by trino-lb
36
+
-In the future more advanced features can be built based on information from the Trino events
37
37
38
38
Downsides:
39
39
40
-
* It requires active configuration on the Trino side, namely setting up the HTTP event listener
41
-
* Trino clients need to have network access to the coordinators
40
+
-It requires active configuration on the Trino side, namely setting up the HTTP event listener
41
+
-Trino clients require network access to the coordinator
42
42
43
43
A sample configuration in Trino can look something like the following.
44
-
Please have a look at the [kuttl tests](https://github.com/stackabletech/trino-lb/tree/feat/trino-query-events/tests/templates/kuttl/) for complete examples.
44
+
Please have a look at the [kuttl tests](https://github.com/stackabletech/trino-lb/tree/main/tests/templates/kuttl/) for complete examples.
45
45
46
-
Please note that you can not disable the TLS certificate check, in this case secret-operator from the Stackable Data Platform is used to automatically provision valid TLS certificates.
46
+
Please note that you cannot disable the TLS certificate check. In the example below, the secret-operator from the Stackable Data Platform is used to provision valid TLS certificates automatically.
0 commit comments