Skip to content

Commit 12ae7c0

Browse files
committed
Remove custom variant code as commenRemove custom variant code comment
1 parent cc566e8 commit 12ae7c0

1 file changed

Lines changed: 2 additions & 15 deletions

File tree

  • rust/operator-binary/src/crd/catalog

rust/operator-binary/src/crd/catalog/mod.rs

Lines changed: 2 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -70,6 +70,8 @@ pub mod versioned {
7070
pub config_removals: Vec<String>,
7171
}
7272

73+
// We might implement more variants in the future. See the CRD decision in
74+
// https://github.com/stackabletech/trino-operator/issues/891 for details.
7375
#[derive(Clone, Debug, Deserialize, JsonSchema, PartialEq, Serialize)]
7476
#[serde(rename_all = "camelCase")]
7577
pub enum TrinoCatalogNameSpec {
@@ -85,24 +87,9 @@ pub mod versioned {
8587
/// requires quoting for catalogs containing `-` characters. This mechanism allows
8688
/// you to use valid Kubernetes names, but keeps the convenience of using `_` in
8789
/// catalog names.
88-
//
89-
// /// In case you need complete flexibility over the catalog name, you can use
90-
// /// `name.custom`.
9190
#[serde(default)]
9291
replace_hyphens_with_underscores: bool,
9392
},
94-
// As requested in https://github.com/stackabletech/trino-operator/issues/891 we are not
95-
// implementing the custom variant yet. Please re-open or create a new decision before
96-
// implementing this.
97-
//
98-
// /// Specify the name of the catalog as it shows up in Trino.
99-
// ///
100-
// /// It is your responsibility to make sure that no catalog names clash, the operator will
101-
// /// raise an error in that case.
102-
// ///
103-
// /// TIP: If you only want to replace `-` with `_` use
104-
// /// `name.inferred.replaceHyphensWithUnderscores` instead.
105-
// Custom(String),
10693
}
10794
}
10895

0 commit comments

Comments
 (0)