integration test successful

Author: razvan

tests/templates/kuttl/client-spooling/03-install-test-helper.yaml

@@ -16,7 +16,7 @@ spec:
       resources:
         requests:
           cpu: "250m"
-          memory: "512Mi"
+          memory: "1024Mi"
         limits:
           cpu: "250m"
-          memory: "1024Mi"
+          memory: "2048Mi"

tests/templates/kuttl/client-spooling/04_check-fte.py

@@ -1,6 +1,7 @@
 #!/usr/bin/env python
 import trino
 import argparse
+import urllib3
 
 
 def get_connection(coordinator):
@@ -17,6 +18,8 @@ def get_connection(coordinator):
 
 
 if __name__ == "__main__":
+    urllib3.disable_warnings(urllib3.exceptions.InsecureRequestWarning)
+
     # Construct an argument parser
     all_args = argparse.ArgumentParser()
 
@@ -35,42 +38,25 @@ def get_connection(coordinator):
     try:
         cursor = conn.cursor()
 
-        # Test that TPCH connector is working
-        cursor.execute("SELECT COUNT(*) FROM tpch.tiny.nation")
-        result = cursor.fetchone()
-        if result[0] != 25:  # TPCH tiny.nation has 25 rows
-            print(f"TPCH test failed: expected 25 nations, got {result[0]}")
-            exit(-1)
-
-        print("TPCH connector test passed")
+        print("🚜 fetching many rows from Trino to trigger spooling...")
 
-        # Test a more complex query
-        cursor.execute("""
-            SELECT
-                nation.name,
-                COUNT(*) AS num_cust
-            FROM
-                tpch.tiny.customer
-            JOIN
-                tpch.tiny.nation ON customer.nationkey = nation.nationkey
-            GROUP BY
-                nation.name
-            ORDER BY
-                num_cust DESC
-        """)
-        results = cursor.fetchall()
-        if len(results) == 0:
-            print("Complex query returned no results")
-            exit(-1)
+        cursor.execute("SELECT * FROM tpch.sf100.customer")
+        customer_count = 0
+        batch = 10
+        while batch > 0:
+            print(f"⏳ fetching batch {batch} of 1000 rows...")
+            cursor.fetchmany(1_000)
+            customer_count += 1_000
+            batch = batch - 1
+        # assert customer_count == 15_000_000, f"TPCH test failed: expected 15 mil customers, got {customer_count}"
 
-        print("Complex query test passed")
+        print("🎉 major success!")
 
         cursor.close()
-        conn.close()
 
     except Exception as e:
-        print(f"Test failed with error: {e}")
-        import traceback
+        print(f"💀 oh noes! cannot fetch customers from Trino: {e}")
+        raise e
 
-        traceback.print_exc()
-        exit(-1)
+    finally:
+        conn.close()

tests/templates/kuttl/client-spooling/05-assert.yaml

@@ -4,9 +4,9 @@ kind: TestAssert
 timeout: 300
 commands:
   - script: kubectl exec -n $NAMESPACE trino-test-helper -- python /tmp/check-active-workers.py -u admin -p "" -c trino-coordinator -w 2
+  - script: kubectl exec -n $NAMESPACE deployment/minio -- mc alias set local https://localhost:9000 minioAccessKey minioSecretKey --api S3v4
   # Verify that the spooling bucket contains data
   - script: |
-      kubectl exec -n $NAMESPACE deployment/minio -- mc alias set local https://localhost:9000 minioAccessKey minioSecretKey --api S3v4
       count=$(kubectl exec -n $NAMESPACE deployment/minio -- mc stat --insecure local/spooling-bucket | awk '/Objects count:/ {print $3}')
       if [ "$count" -gt 0 ]; then
         echo "Objects count is $count (> 0)"