Skip to content

Commit 34e9783

Browse files
maltesanderadwk67claude
authored
feat: remove product config & clean up (#897)
* feat: remove product config & clean up * docs: remove product config CLI paramter * fix: add todo to reference file name enum * docs: adapted changelog * docs: fix file name doc location * fix: move graceful shutdown to build module * fix: remove uuid dependency * Update rust/operator-binary/src/controller/build/properties/config_properties.rs Co-authored-by: Andrew Kenworthy <1712947+adwk67@users.noreply.github.com> * Update rust/operator-binary/src/controller/build/config_map.rs Co-authored-by: Andrew Kenworthy <1712947+adwk67@users.noreply.github.com> * docs: remove product config from env variables * fix: rename validated -> validated_cluster * refactor: move logging to build step * refactor: consume the config-file writer from stackable-operator Replace the hand-rolled Java-properties escaper (rust/operator-binary/src/controller/build/properties/writer.rs) with stackable_operator::v2::config_file_writer (moved there via operator-rs #1217 on the smooth-operator branch). A thin adapter in properties/mod.rs maps trino's String-valued maps onto the writer's Option<String>-valued interface; the kuttl-pinned escape behaviours stay covered by unit tests against the shared writer. Unlike the other operators this is not a pure relocation: the hand-rolled escaper (introduced on this branch, never released) had unintentionally diverged from the product-config writer it replaced. A differential test showed 8 divergences, all unreachable from operator defaults (the kuttl smoke snapshot's 157 property lines are unaffected): - inner/trailing spaces in values: now escaped (read-back identical per the Java properties spec) - tab/newline/CR in values: now escaped (the raw output was malformed) - non-ASCII: now ISO-8859-1-spec behaviour again (error on Latin-1-range values, \uXXXX beyond) instead of raw UTF-8 pass-through This restores the exact serialization behaviour of the released operator, which renders via the identical product-config code. The base dependency tag moves from stackable-operator-0.111.0 to 0.111.1, matching the other operators; cargo only substitutes a [patch] whose package version matches, and the smooth-operator branch carries 0.111.1. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> * fix: improve map rendering * refactor: make namespace non option and pass trough catalogs * refactor: use option free properties writer * refactor: remove ownerrefs from builder functions * refactor: switch to EnvVarSet * fix: missing parenthesis from main merge * fix: bump stackable-operator for non optional KeyValueConfigOverrides * fix: move catalog configmap to builder module and use ValidatedCluster * fix: format change due to merge moved pdbs in a listener dependency an was never deployed for workers. * moved validated structs to controller/mod.rs, renamed controller -> trino_controller, pass through validated cluster * refactor: switch to v2 JavaCommonConfig * chore: bump stackable-operator * refactor: reduce RolegroupRef usage * refactor: introduce ValidatedTrinoConfig * refactor: move k8s resources to builder/resource * refactor: move sts to resource folder * test: add vector.toml test setup * refactor: consolidatev2 logging * refactor: move raw cluster methods to ValidatedCluster * refactor: move to v2 pdb and clusteresources * refactor: use v2 labeling * refactor: switch to v2 STACKABLE_LOG_DIR * refactor: switch to v2 ownerref, remove results * refactor: use restarter_ignore_secret_annotations * refactor: use v2 SecretName * refactor: use v2 SecretClass in CRD * refactor: use SecretName, ListenerName, ConfigMapName * refactor: remove redudant paramters from build_statefulset * refactor: cleanup build_statefulset and tls_volume parameters * refactor: introduce ValidatedRoleConfig * refactor: add ValidatedCluster::object_meta helper for child resource metadata * fix: move hardcoded values to constants * chore: improve vector tests * fix(doc): remove stale comments * chore: bump dependencies * fix: adujust to optimal replicas * refactor: consolidate authentication build * refactor: move constants and use Port type * fix: add internal tls helper * fix: remove obsolete comment * chore: remove obsolete error variants * fix: remove insert loops * fix: consolidate listener class default, keystore / truststore constants * fix: consolidate catalog naming * fix: use listener role group placeholder * fix: use checked namespace im opa config * fix: consolidate coordinator role extraction * fix: add s3_tls_truststore_commands & cleanup * refactor: move command.rs to build, use ConfigFileNames, remove v2 / upstream references * refactor: use v2 types * test: improve test helper & add auth tests * test: improve unit tes coverage * bump op-rs to 0.112.0 * chore: bump remaining test examples 479 -> 481 * chore: replace promethues label & annotations with op-rs v2 helper * fix: missing trino version switch 479 -> 481 * bump anyhow to 1.0.103 due to RUSTSEC advisory * fix test assert for openshift --------- Co-authored-by: Andrew Kenworthy <1712947+adwk67@users.noreply.github.com> Co-authored-by: Andrew Kenworthy <andrew.kenworthy@stackable.tech> Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
1 parent 3eecab9 commit 34e9783

75 files changed

Lines changed: 6781 additions & 6087 deletions

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

CHANGELOG.md

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,8 @@ All notable changes to this project will be documented in this file.
2222
- Bump `stackable-operator` to 0.111.0 and `kube` to 3.1.0 ([#878], [#884]).
2323
- Internal operator refactoring: introduce dereference() and validate() steps in the reconciler ([#889]).
2424
- test: Bump vector-aggregator to 0.55.0, replace /graphql call with gRPC call ([#895]).
25+
- BREAKING: Removed product-config machinery. This is a breaking change in terms of configuration.
26+
Users relying on the product-config `properties.yaml` file have to set these properties via the CRD ([#897]).
2527

2628
### Fixed
2729

@@ -39,6 +41,7 @@ All notable changes to this project will be documented in this file.
3941
[#884]: https://github.com/stackabletech/trino-operator/pull/884
4042
[#889]: https://github.com/stackabletech/trino-operator/pull/889
4143
[#895]: https://github.com/stackabletech/trino-operator/pull/895
44+
[#897]: https://github.com/stackabletech/trino-operator/pull/897
4245
[#900]: https://github.com/stackabletech/trino-operator/pull/900
4346

4447
## [26.3.0] - 2026-03-16

0 commit comments

Comments
 (0)