remove the "enabled" property

Author: razvan

deploy/helm/trino-operator/crds/crds.yaml

@@ -115,9 +115,6 @@ spec:
                           default: {}
                           description: The `configOverrides` allow overriding arbitrary client protocol properties.
                           type: object
-                        enabled:
-                          description: Enable spooling protocol.
-                          type: boolean
                         filesystem:
                           oneOf:
                             - required:
@@ -272,7 +269,6 @@ spec:
                         location:
                           type: string
                       required:
-                        - enabled
                         - filesystem
                         - location
                       type: object

docs/modules/trino/pages/usage-guide/client-spooling-protocol.adoc

@@ -17,16 +17,14 @@ To enable it, you need to set the `spec.clusterConfig.clientSpoolingProtocol` co
 spec:
   clusterConfig:
     clientSpoolingProtocol:
-      enabled: true # <1>
-      location: "s3://spooling-bucket/trino/" # <2>
+      location: "s3://spooling-bucket/trino/" # <1>
       filesystem:
-        s3: # <3>
+        s3: # <2>
           connection:
             reference: "minio"
 ----
-<1> Enables the client spooling protocol
-<2> Specifies the location where spooled data will be stored. This example uses an S3 bucket.
-<3> Configures the filesystem type for spooling. Only S3 is supported currently via the custom resource definition.
+<1> Specifies the location where spooled data will be stored. This example uses an S3 bucket.
+<2> Configures the filesystem type for spooling. Only S3 is supported currently via the custom resource definition.
 
 The operator automatically fills in additional settings required by Trino, such as the `protocol.spooling.shared-secret-key`.
 Users can change the contents of the `spooling-manager.properties` file by adding entries to the optional `spec.clusterConfig.clientSpoolingProtocol.config_overrides` map.

rust/operator-binary/src/crd/client_protocol.rs

@@ -26,9 +26,6 @@ const SPOOLING_S3_AWS_SECRET_KEY: &str = "SPOOLING_S3_AWS_SECRET_KEY";
 #[derive(Clone, Debug, Deserialize, JsonSchema, PartialEq, Serialize)]
 #[serde(rename_all = "camelCase")]
 pub struct ClientSpoolingProtocolConfig {
-    /// Enable spooling protocol.
-    pub enabled: bool,
-
     // Spool segment location. Each Trino cluster must have its own
     // location independent of any other clusters.
     pub location: String,
@@ -134,10 +131,7 @@ impl ResolvedSpoolingProtocolConfig {
 
         // Enable spooling protocol
         resolved_config.config_properties.extend([
-            (
-                "protocol.spooling.enabled".to_string(),
-                config.enabled.to_string(),
-            ),
+            ("protocol.spooling.enabled".to_string(), "true".to_string()),
             (
                 "protocol.spooling.shared-secret-key".to_string(),
                 format!("${{ENV:{secret}}}", secret = ENV_SPOOLING_SECRET),
@@ -259,7 +253,6 @@ mod tests {
     #[tokio::test]
     async fn test_spooling_config() {
         let config = ClientSpoolingProtocolConfig {
-            enabled: true,
             location: "s3://my-bucket/spooling".to_string(),
             filesystem: SpoolingFileSystemConfig::S3(S3SpoolingConfig {
                 connection:
@@ -300,7 +293,6 @@ mod tests {
     #[tokio::test]
     async fn test_spooling_config_overrides() {
         let config = ClientSpoolingProtocolConfig {
-            enabled: true,
             location: "s3://my-bucket/spooling".to_string(),
             filesystem: SpoolingFileSystemConfig::S3(S3SpoolingConfig {
                 connection: