Skip to content

Commit a020f50

Browse files
committed
add comment to function
1 parent 83f8879 commit a020f50

1 file changed

Lines changed: 5 additions & 0 deletions

File tree

rust/operator-binary/src/controller.rs

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -950,6 +950,11 @@ fn build_rolegroup_config_map(
950950
})
951951
}
952952

953+
// This is unsafe because it does not do any escaping of keys or values.
954+
// It is needed because the `product_config::writer::to_java_properties_string`
955+
// function escapes `:` characters in values.
956+
// This breaks values like ${file:UTF-8:/path/to/file} which are used
957+
// for S3 credentials.
953958
fn unsafe_java_properties_string(map: &BTreeMap<String, String>) -> String {
954959
map.iter()
955960
.map(|(k, v)| format!("{}={}", k, v))

0 commit comments

Comments
 (0)