Skip to content

Commit d464baa

Browse files
committed
add comment to function
1 parent e028cf4 commit d464baa

1 file changed

Lines changed: 5 additions & 0 deletions

File tree

rust/operator-binary/src/controller.rs

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -929,6 +929,11 @@ fn build_rolegroup_config_map(
929929
})
930930
}
931931

932+
// This is unsafe because it does not do any escaping of keys or values.
933+
// It is needed because the `product_config::writer::to_java_properties_string`
934+
// function escapes `:` characters in values.
935+
// This breaks values like ${file:UTF-8:/path/to/file} which are used
936+
// for S3 credentials.
932937
fn unsafe_java_properties_string(map: &BTreeMap<String, String>) -> String {
933938
map.iter()
934939
.map(|(k, v)| format!("{}={}", k, v))

0 commit comments

Comments
 (0)