Skip to content

Commit e1cb342

Browse files
committed
fix: do not recreate immutable secrets with different values
1 parent 6cdffb9 commit e1cb342

2 files changed

Lines changed: 10 additions & 1 deletion

File tree

CHANGELOG.md

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,12 @@ All notable changes to this project will be documented in this file.
44

55
## [Unreleased]
66

7+
### Fixed
8+
9+
- Do not make internal secrets immutable. Immutable secrets are cached and (accidental) deletes can render the cluster unusable ([#875]).
10+
11+
[#875]: https://github.com/stackabletech/trino-operator/pull/875
12+
713
## [26.3.0] - 2026-03-16
814

915
## [26.3.0-rc1] - 2026-03-16

rust/operator-binary/src/controller.rs

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1536,7 +1536,10 @@ async fn create_random_secret(
15361536
internal_secret.insert(secret_key.to_string(), get_random_base64(secret_byte_size));
15371537

15381538
let secret = Secret {
1539-
immutable: Some(true),
1539+
// This secret used to be immutable but immutable secrets cannot be modified
1540+
// as they are heavily cached by Kubernetes.
1541+
// Different pods with different secrets will render the cluster unusable.
1542+
immutable: Some(false),
15401543
metadata: ObjectMetaBuilder::new()
15411544
.name(secret_name)
15421545
.namespace_opt(trino.namespace())

0 commit comments

Comments
 (0)