Skip to content

Commit e387fba

Browse files
Apply suggestions from code review
Co-authored-by: maltesander <malte.sander.it@gmail.com>
1 parent 73bc2b6 commit e387fba

2 files changed

Lines changed: 6 additions & 6 deletions

File tree

rust/operator-binary/src/catalog/commons.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -126,7 +126,7 @@ impl ExtendCatalogConfig for HdfsConnection {
126126
// Since Trino 458, fs.hadoop.enabled defaults to false.
127127
catalog_config.add_property("fs.hadoop.enabled", "true");
128128

129-
let hdfs_site_dir = format!("{CONFIG_DIR_NAME}/catalog/{catalog_name}/hdfs-config",);
129+
let hdfs_site_dir = format!("{CONFIG_DIR_NAME}/catalog/{catalog_name}/hdfs-config");
130130
catalog_config.add_property(
131131
"hive.config.resources",
132132
format!("{hdfs_site_dir}/core-site.xml,{hdfs_site_dir}/hdfs-site.xml"),

rust/operator-binary/src/crd/catalog/mod.rs

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -75,16 +75,16 @@ pub mod versioned {
7575
pub enum TrinoCatalogNameSpec {
7676
/// Infer the catalog name from the `.metadata.name` of the TrinoCatalog resource.
7777
///
78-
/// This ensures that no catalog names clash, as their can only be one TrinoCatalog with a
78+
/// This ensures that no catalog names clash, as there can only be one TrinoCatalog with a
7979
/// given name.
8080
#[serde(rename_all = "camelCase")]
8181
Inferred {
82-
/// Wether hyphens (`-`) in the name of the catalog should be replaced by underscores (`_`).
82+
/// Whether hyphens (`-`) in the name of the catalog should be replaced by underscores (`_`).
8383
///
8484
/// This is recommended because Kubernetes only allows `a-z` and `-`, while Trino
85-
/// requires quoting for catalogs containing `-` characters, but not for `_`. This mechanism
86-
/// allows you to use valid Kubernetes names, but keeps the convenience of `_` in catalog
87-
/// names.
85+
/// requires quoting for catalogs containing `-` characters. This mechanism allows
86+
/// you to use valid Kubernetes names, but keeps the convenience of using `_` in
87+
/// catalog names.
8888
//
8989
// /// In case you need complete flexibility over the catalog name, you can use
9090
// /// `name.custom`.

0 commit comments

Comments
 (0)