Skip to content

fix!: Remove unused PVCs which caused problems #769

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sbernauer merged 6 commits into from
Jul 7, 2025
Merged

fix!: Remove unused PVCs which caused problems #769

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
71b7e0b
fix!: Remove unused PVCs which caused problems
sbernauer Jul 3, 2025
25c05b9
changelog
sbernauer Jul 3, 2025
e08b1ba
docs: Document why we need to provide an empty struct
sbernauer Jul 3, 2025
a69e976
remove missleading leftover comment
sbernauer Jul 3, 2025
265d33c
Update tests and docs
sbernauer Jul 3, 2025
2f46832
Merge branch 'main' into fix/remove-pvcs
sbernauer Jul 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,16 @@ All notable changes to this project will be documented in this file.

- Use `json` file extension for log files ([#733]).
- Fix a bug where changes to ConfigMaps that are referenced in the TrinoCluster spec didn't trigger a reconciliation ([#734]).
- BREAKING: The PersistentVolumeClaims for coordinator and workers have been removed ([#769])
- They caused problems, as Trino kept it's process ID in `/stackable/data/var/run/launcher.pid`.
A forceful stop (e.g. OOMKilled) could result in a leftover PID in this file.
In this case Trino would refuse startup with `trino ERROR: already running as 21`.
As the PersistentVolumeClaims didn't store any actual data, they have been removed.
- Upgrading will result in the error message `Failed to reconcile object [...]: Forbidden: updates to statefulset spec for fields other than [...] are forbidden`
as Kubernetes currently does not allow changing the `volumeClaimTemplates` field. Simply delete the mentioned StatefulSet, the operator will re-create it.
- You might want to clean up now useless PVCs.
Tip: You can list all Trino-related PVCs using `kubectl get pvc -l app.kubernetes.io/name=trino`.
- The `.spec.(coordinators|workers).config.resources.storage.data` field has been removed, as it's not needed anymore.

### Removed

Expand All @@ -56,6 +66,7 @@ All notable changes to this project will be documented in this file.
[#753]: https://github.com/stackabletech/trino-operator/pull/753
[#755]: https://github.com/stackabletech/trino-operator/pull/755
[#760]: https://github.com/stackabletech/trino-operator/pull/760
[#769]: https://github.com/stackabletech/trino-operator/pull/769

## [25.3.0] - 2025-03-21

Expand Down
Loading