fix: replace promethues annotations and label with v2 helper

Author: maltesander

rust/operator-binary/src/zk_controller/build/resource/service.rs

@@ -1,7 +1,9 @@
 use stackable_operator::{
     k8s_openapi::api::core::v1::{Service, ServicePort, ServiceSpec},
-    kvp::{Annotations, Labels},
-    v2::types::{common::Port, operator::RoleGroupName},
+    v2::{
+        builder::service::{Scheme, Scraping, prometheus_annotations, prometheus_labels},
+        types::operator::RoleGroupName,
+    },
 };
 
 use crate::{
@@ -74,8 +76,13 @@ pub(crate) fn build_server_rolegroup_metrics_service(
                 .metrics_service_name(),
             role_group_name,
         )
-        .with_labels(prometheus_labels())
-        .with_annotations(prometheus_annotations(metrics_port.clone()))
+        .with_labels(prometheus_labels(&Scraping::Enabled))
+        .with_annotations(prometheus_annotations(
+            &Scraping::Enabled,
+            &Scheme::Http,
+            "/metrics",
+            &metrics_port,
+        ))
         .build();
 
     let service_spec = ServiceSpec {
@@ -108,23 +115,3 @@ pub(crate) fn build_server_rolegroup_metrics_service(
         status: None,
     }
 }
-
-/// Common labels for Prometheus
-fn prometheus_labels() -> Labels {
-    Labels::try_from([("prometheus.io/scrape", "true")]).expect("should be a valid label")
-}
-
-/// Common annotations for Prometheus
-///
-/// These annotations can be used in a ServiceMonitor.
-///
-/// see also <https://github.com/prometheus-community/helm-charts/blob/prometheus-27.32.0/charts/prometheus/values.yaml#L983-L1036>
-fn prometheus_annotations(metrics_port: Port) -> Annotations {
-    Annotations::try_from([
-        ("prometheus.io/path".to_owned(), "/metrics".to_owned()),
-        ("prometheus.io/port".to_owned(), metrics_port.to_string()),
-        ("prometheus.io/scheme".to_owned(), "http".to_owned()),
-        ("prometheus.io/scrape".to_owned(), "true".to_owned()),
-    ])
-    .expect("should be valid annotations")
-}