Apply suggestions from code review

Co-authored-by: Malte Sander <contact@maltesander.com>

Author: NickLarsenNZ

docs/modules/zookeeper/pages/usage_guide/listenerclass.adoc

@@ -4,7 +4,7 @@
 Apache ZooKeeper offers an API. The Operator deploys a service called `<name>` (where `<name>` is the name of the ZookeeperCluster) through which ZooKeeper can be reached.
 
 The operator deploys a xref:listener-operator:listener.adoc[Listener] for the Server pods.
-The listener defaults to only being accessible from within the Kubernetes cluster, but this can be changed by setting `.spec.nodes.config.listenerClass`:
+The listener defaults to only being accessible from within the Kubernetes cluster, but this can be changed by setting `.spec.servers.roleConfig.listenerClass`:
 
 [source,yaml]
 ----

rust/operator-binary/src/crd/mod.rs

@@ -164,7 +164,7 @@ pub mod versioned {
         #[serde(flatten)]
         pub common: GenericRoleConfig,
 
-        /// This field controls which [ListenerClass](DOCS_BASE_URL_PLACEHOLDER/listener-operator/listenerclass.html) is used to expose the ZooKeeper nodes.
+        /// This field controls which [ListenerClass](DOCS_BASE_URL_PLACEHOLDER/listener-operator/listenerclass.html) is used to expose the ZooKeeper servers.
         #[serde(default = "default_listener_class")]
         pub listener_class: String,
     }

rust/operator-binary/src/listener.rs

@@ -64,7 +64,7 @@ pub fn build_role_listener(
                 ZK_CONTROLLER_NAME,
                 &resolved_product_image.app_version_label,
                 &zk_role.to_string(),
-                "global", // TODO (@NickLarsenNZ): update build_recommended_labels to have an optional role_group
+                "none", // TODO (@NickLarsenNZ): update build_recommended_labels to have an optional role_group
             ))
             .context(RecommendedLabelsSnafu)?
             .build(),
@@ -81,7 +81,7 @@ pub fn build_role_listener(
 
 // TODO (@NickLarsenNZ): This could be a method we can put on a Resource that takes a role_name
 pub fn role_listener_name(zk: &v1alpha1::ZookeeperCluster, zk_role: &ZookeeperRole) -> String {
-    // TODO (@NickLarsenNZ): Make a convention, do we use name_any() and allow empty string? or metadata.name.expect, or handle the error?
+    // TODO (@NickLarsenNZ): Make a convention, do we use name_any() and allow empty string? or handle the error (as unlikely as it would be)?
     format!("{zk}-{zk_role}", zk = zk.name_any())
 }
 

rust/operator-binary/src/znode_controller.rs

@@ -360,7 +360,7 @@ async fn reconcile_cleanup(
 /// This uses the _Server_ Role [Listener] address because it covers ZooKeeper replicas across all
 /// RoleGroups.
 /// This does mean that when the listenerClass is `external-stable`, the operator will need to be
-/// able to access the external adress (eg: Load Balancer).
+/// able to access the external address (eg: Load Balancer).
 ///
 /// [Listener]: ::stackable_operator::crd::listener::v1alpha1::Listener
 // NOTE (@NickLarsenNZ): If we want to keep this traffic internal, we would need to choose one of