refactor(security): drop async ZookeeperSecurity::new_from_zookeeper_cluster

Author: maltesander

rust/operator-binary/src/crd/security.rs

@@ -19,28 +19,21 @@ use stackable_operator::{
             },
         },
     },
-    client::Client,
     commons::secret_class::SecretClassVolumeProvisionParts,
     crd::authentication::core,
     k8s_openapi::api::core::v1::Volume,
     shared::time::Duration,
 };
 
 use crate::{
-    crd::{
-        authentication::{self, ResolvedAuthenticationClasses},
-        tls, v1alpha1,
-    },
+    crd::{authentication::ResolvedAuthenticationClasses, tls, v1alpha1},
     zk_controller::LISTENER_VOLUME_NAME,
 };
 
 type Result<T, E = Error> = std::result::Result<T, E>;
 
 #[derive(Snafu, Debug)]
 pub enum Error {
-    #[snafu(display("failed to process authentication class"))]
-    InvalidAuthenticationClassConfiguration { source: authentication::Error },
-
     #[snafu(display("failed to build TLS volume for {volume_name:?}"))]
     BuildTlsVolume {
         source: SecretOperatorVolumeSourceBuilderError,
@@ -96,21 +89,6 @@ impl ZookeeperSecurity {
     pub const STORE_PASSWORD_ENV: &'static str = "STORE_PASSWORD";
     pub const SYSTEM_TRUST_STORE_DIR: &'static str = "/etc/pki/java/cacerts";
 
-    /// Create a `ZookeeperSecurity` struct from the Zookeeper custom resource and resolve
-    /// all provided `AuthenticationClass` references.
-    pub async fn new_from_zookeeper_cluster(
-        client: &Client,
-        zk: &v1alpha1::ZookeeperCluster,
-    ) -> Result<Self, Error> {
-        let resolved_authentication_classes = authentication::resolve_authentication_classes(
-            client,
-            &zk.spec.cluster_config.authentication,
-        )
-        .await
-        .context(InvalidAuthenticationClassConfigurationSnafu)?;
-        Ok(Self::new(zk, resolved_authentication_classes))
-    }
-
     /// Build a `ZookeeperSecurity` from a [`v1alpha1::ZookeeperCluster`] and already-resolved
     /// [`ResolvedAuthenticationClasses`]. Synchronous; intended to be called from the validate
     /// step of the controllers.