Skip to content

Commit 8611d1e

Browse files
Remove explicit Torchvision dep and cleanup docs
1 parent 42fee5b commit 8611d1e

3 files changed

Lines changed: 14 additions & 4 deletions

File tree

README.md

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -32,6 +32,8 @@ Each operation is complete with a PyTorch-only reference implementation (and som
3232
- GEMM
3333
- Mixed-precision
3434
- Scaled
35+
- Vision
36+
- Non-Max Suppression (NMS)
3537
- vLLM
3638
- KV cache operations
3739
- Copy blocks
@@ -99,6 +101,7 @@ We were inspired by and leverage components of the following libraries:
99101

100102
- [bitsandbytes](https://github.com/bitsandbytes-foundation/bitsandbytes)
101103
- [GemLite](https://github.com/mobiusml/gemlite)
104+
- [Torchvision](https://github.com/pytorch/vision)
102105
- [vLLM](https://github.com/vllm-project/vllm)
103106

104107
## License

docs/getting_started/developer_environment.md

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -95,3 +95,14 @@ In order to use them, you can install vLLM (`pip install vllm`) and set the envi
9595
pip install vllm==0.9.1
9696
CONCH_ENABLE_VLLM=1 python benchmarks/paged_attention_benchmark.py
9797
```
98+
99+
### Optional: Benchmarking against Torchvision
100+
101+
Some unit tests/benchmarks allow comparison to CUDA implementations of operations from Torchvision (rather than PyTorch-reference implementations).
102+
In order to use them, you can install Torchvision (`pip install torchvision`) and set the environment variable `CONCH_ENABLE_TORCHVISION=1`.
103+
104+
```bash
105+
# Note: add `--extra-index-url https://download.pytorch.org/whl/rocm6.2.4` on ROCm
106+
pip install torchvision==0.22
107+
CONCH_ENABLE_TORCHVISION=1 python benchmarks/nms_benchmark.py
108+
```

setup.py

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,6 @@
66
from setuptools import setup
77

88
_TORCH_VERSION: Final = "2.7.0"
9-
_TORCHVISION_VERSION: Final = "0.22"
109
_TRITON_VERSION: Final = "3.3.0"
1110

1211
_REQUIREMENTS: Final = [
@@ -17,23 +16,20 @@
1716
# --extra-index-url https://download.pytorch.org/whl/cpu
1817
_DEFAULT_PLATFORM_REQUIREMENTS: Final = [
1918
f"torch=={_TORCH_VERSION}",
20-
f"torchvision=={_TORCHVISION_VERSION}",
2119
f"triton>={_TRITON_VERSION}",
2220
]
2321

2422
# For ROCm:
2523
# --extra-index-url https://download.pytorch.org/whl/rocm6.2.4
2624
_ROCM_PLATFORM_REQUIREMENTS: Final = [
2725
f"torch=={_TORCH_VERSION}+rocm6.2.4",
28-
f"torchvision=={_TORCHVISION_VERSION}+rocm6.2.4",
2926
f"pytorch-triton-rocm>={_TRITON_VERSION}",
3027
]
3128

3229
# For XPU:
3330
# --extra-index-url https://download.pytorch.org/whl/xpu
3431
_XPU_PLATFORM_REQUIREMENTS: Final = [
3532
f"torch=={_TORCH_VERSION}+xpu",
36-
f"torchvision=={_TORCHVISION_VERSION}+xpu",
3733
f"pytorch-triton-xpu>={_TRITON_VERSION}",
3834
]
3935

0 commit comments

Comments
 (0)