Skip to content

Commit d82b72d

Browse files
committed
break out golden example tests as manual for CI
1 parent 5e35cf3 commit d82b72d

3 files changed

Lines changed: 62 additions & 2 deletions

File tree

.bazelrc

Lines changed: 25 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,27 @@
1-
# Updated to C++17 for protobuf compatibility
1+
# =========================================================================
2+
# STARTUP
3+
# =========================================================================
4+
5+
# Use blake3 as digest function instead of the much slower default sha256.
6+
startup --digest_function=blake3
7+
8+
# =========================================================================
9+
# COMMON
10+
# =========================================================================
11+
12+
# Use '+' instead of the legacy '~' when resolving repo names.
13+
common --incompatible_use_plus_in_repo_names
14+
15+
# =========================================================================
16+
# BUILD
17+
# =========================================================================
18+
19+
# Don't leak PATH and LD_LIBRARY_PATH into the build.
20+
# build --incompatible_strict_action_env
21+
22+
# Don't use legacy repository rules.
23+
build --incompatible_disable_native_repo_rules
24+
25+
# C++17 for protobuf compatibility
226
build --host_cxxopt=-std=c++17
327
build --cxxopt=-std=c++17

.github/workflows/ci.yaml

Lines changed: 25 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -51,3 +51,28 @@ jobs:
5151
--bazelrc=.bazelrc
5252
test
5353
...
54+
55+
# run this block of manual tests. For some reason when run sequentially
56+
# in the same bazel invocation, one or more will hang / TIMEOUT (300s).
57+
- name: bazel test //example/golden:commonjs_test
58+
run: bazelisk --bazelrc=.github/workflows/ci.bazelrc --bazelrc=.bazelrc test //example/golden:commonjs_test
59+
- name: bazel test //example/golden:cpp_test
60+
run: bazelisk --bazelrc=.github/workflows/ci.bazelrc --bazelrc=.bazelrc test //example/golden:cpp_test
61+
- name: bazel test //example/golden:csharp_test
62+
run: bazelisk --bazelrc=.github/workflows/ci.bazelrc --bazelrc=.bazelrc test //example/golden:csharp_test
63+
- name: bazel test //example/golden:go_test
64+
run: bazelisk --bazelrc=.github/workflows/ci.bazelrc --bazelrc=.bazelrc test //example/golden:go_test
65+
- name: bazel test //example/golden:goembed_test
66+
run: bazelisk --bazelrc=.github/workflows/ci.bazelrc --bazelrc=.bazelrc test //example/golden:goembed_test
67+
- name: bazel test //example/golden:java_test
68+
run: bazelisk --bazelrc=.github/workflows/ci.bazelrc --bazelrc=.bazelrc test //example/golden:java_test
69+
- name: bazel test //example/golden:objc_test
70+
run: bazelisk --bazelrc=.github/workflows/ci.bazelrc --bazelrc=.bazelrc test //example/golden:objc_test
71+
- name: bazel test //example/golden:proto_compiled_sources_test
72+
run: bazelisk --bazelrc=.github/workflows/ci.bazelrc --bazelrc=.bazelrc test //example/golden:proto_compiled_sources_test
73+
- name: bazel test //example/golden:python_test
74+
run: bazelisk --bazelrc=.github/workflows/ci.bazelrc --bazelrc=.bazelrc test //example/golden:python_test
75+
- name: bazel test //example/golden:ruby_test
76+
run: bazelisk --bazelrc=.github/workflows/ci.bazelrc --bazelrc=.bazelrc test //example/golden:ruby_test
77+
- name: bazel test //example/golden:strip_import_prefix_test
78+
run: bazelisk --bazelrc=.github/workflows/ci.bazelrc --bazelrc=.bazelrc test //example/golden:strip_import_prefix_test

example/golden/BUILD.bazel

Lines changed: 12 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -50,54 +50,63 @@ gazelle_testdata_example(
5050
name = "cpp",
5151
srcs = glob(["testdata/cpp/*"]),
5252
extra_module_bazel_content = extra_module_bazel_content,
53+
tags = ["manual"],
5354
)
5455

5556
gazelle_testdata_example(
5657
name = "java",
5758
srcs = glob(["testdata/java/*"]),
5859
extra_module_bazel_content = extra_module_bazel_content,
60+
tags = ["manual"],
5961
)
6062

6163
gazelle_testdata_example(
6264
name = "python",
6365
srcs = glob(["testdata/python/*"]),
6466
extra_module_bazel_content = extra_module_bazel_content,
67+
tags = ["manual"],
6568
)
6669

6770
gazelle_testdata_example(
6871
name = "ruby",
6972
srcs = glob(["testdata/ruby/*"]),
7073
extra_module_bazel_content = extra_module_bazel_content,
74+
tags = ["manual"],
7175
)
7276

7377
gazelle_testdata_example(
7478
name = "csharp",
7579
srcs = glob(["testdata/csharp/*"]),
7680
extra_module_bazel_content = extra_module_bazel_content,
81+
tags = ["manual"],
7782
)
7883

7984
gazelle_testdata_example(
8085
name = "objc",
8186
srcs = glob(["testdata/objc/*"]),
8287
extra_module_bazel_content = extra_module_bazel_content,
88+
tags = ["manual"],
8389
)
8490

8591
gazelle_testdata_example(
8692
name = "commonjs",
8793
srcs = glob(["testdata/commonjs/*"]),
8894
extra_module_bazel_content = extra_module_bazel_content,
95+
tags = ["manual"],
8996
)
9097

9198
gazelle_testdata_example(
9299
name = "go",
93100
srcs = glob(["testdata/go/*"]),
94101
extra_module_bazel_content = extra_module_bazel_content,
102+
tags = ["manual"],
95103
)
96104

97105
gazelle_testdata_example(
98106
name = "gomerge",
99107
srcs = glob(["testdata/gomerge/*"]),
100108
extra_module_bazel_content = extra_module_bazel_content,
109+
tags = ["manual"],
101110
)
102111

103112
gazelle_testdata_example(
@@ -107,6 +116,7 @@ gazelle_testdata_example(
107116
bazel_dep(name = "protobuf", version = "32.0", repo_name = "com_google_protobuf")
108117
""",
109118
strip_prefix = "example/golden/testdata/goembed",
119+
tags = ["manual"],
110120
)
111121

112122
gazelle_testdata_example(
@@ -308,7 +318,6 @@ gazelle_testdata_example(
308318
bazel_dep(name = "protobuf", version = "32.0", repo_name = "com_google_protobuf")
309319
""",
310320
strip_prefix = "example/golden/testdata/starlark_java",
311-
tags = ["manual"], # TODO(pcj): figure out why this one is timing out in CI (gh actions)
312321
)
313322

314323
gazelle_testdata_example(
@@ -318,6 +327,7 @@ gazelle_testdata_example(
318327
bazel_dep(name = "protobuf", version = "32.0", repo_name = "com_google_protobuf")
319328
""",
320329
strip_prefix = "example/golden/testdata/strip_import_prefix",
330+
tags = ["manual"],
321331
test_content = """
322332
func TestBuild(t *testing.T) {
323333
if err := bazel_testing.RunBazel("build", "..."); err != nil {
@@ -340,6 +350,7 @@ gazelle_testdata_example(
340350
bazel_dep(name = "protobuf", version = "32.0", repo_name = "com_google_protobuf")
341351
""",
342352
strip_prefix = "example/golden/testdata/proto_compiled_sources",
353+
tags = ["manual"],
343354
test_content = """
344355
345356
func TestUpdate(t *testing.T) {

0 commit comments

Comments
 (0)