Skip to content

fix: --compact with --json depUrl #347

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Aslemammad merged 3 commits into from
Mar 28, 2025
Merged

fix: --compact with --json depUrl #347

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
91cc886
fix: --compact with --json depUrl
AmirSa12 Mar 28, 2025
642c284
lint
AmirSa12 Mar 28, 2025
9c828be
update
AmirSa12 Mar 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions packages/cli/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -221,8 +221,9 @@ const main = defineCommand({
await verifyCompactMode(pJson.name);
}

const formattedSha = isCompact ? abbreviateCommitHash(sha) : sha;
const depUrl = new URL(
`/${owner}/${repo}/${pJson.name}@${sha}`,
`/${owner}/${repo}/${pJson.name}@${formattedSha}`,
apiUrl,
).href;
deps.set(pJson.name, depUrl);
Expand All @@ -231,7 +232,7 @@ const main = defineCommand({
const resource = await fetch(depUrl);
if (resource.ok) {
console.warn(
`${pJson.name}@${abbreviateCommitHash(sha)} was already published on ${depUrl}`,
`${pJson.name}@${formattedSha} was already published on ${depUrl}`,
);
}

Expand Down