Skip to content

fix: commentWithDev option apply template#455

Merged
AmirSa12 merged 2 commits into
stackblitz-labs:mainfrom
btea:fix/commentWithDev-option-apply-template
Feb 7, 2026
Merged

fix: commentWithDev option apply template#455
AmirSa12 merged 2 commits into
stackblitz-labs:mainfrom
btea:fix/commentWithDev-option-apply-template

Conversation

@btea

@btea btea commented Feb 7, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@btea

btea commented Feb 7, 2026

Copy link
Copy Markdown
Contributor Author

When I added the commentWithDev option to the unocss repository, I saw that they were using template mode, and then I realized that the template content did not respect the commentWithDev option. 😄

@AmirSa12

AmirSa12 commented Feb 7, 2026

Copy link
Copy Markdown
Member

When I added the commentWithDev option to the unocss repository, I saw that they were using template mode, and then I realized that the template content did not respect the commentWithDev option. 😄

Thanks for taking care of it. anything else you want to tweak in this PR?

@btea

btea commented Feb 7, 2026

Copy link
Copy Markdown
Contributor Author

I've been thinking about this. Should the commands in the template file respect the packageManager options? If multiple values ​​are passed, should I add multiple installation commands to the README file?

@AmirSa12

AmirSa12 commented Feb 7, 2026

Copy link
Copy Markdown
Member

I've been thinking about this. Should the commands in the template file respect the packageManager options? If multiple values ​​are passed, should I add multiple installation commands to the README file?

I think the UX should be consistent, so yeah. what do you think?

@btea

btea commented Feb 7, 2026

Copy link
Copy Markdown
Contributor Author

However, the templates on the stackbltiz website are installed using npm by default, so keeping it as it is is sufficient.

Of course, generating multiple installation links in the readme doesn't seem to have any impact.

@AmirSa12 AmirSa12 merged commit 1c7fc39 into stackblitz-labs:main Feb 7, 2026
4 of 5 checks passed
@btea btea deleted the fix/commentWithDev-option-apply-template branch February 7, 2026 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants