Skip to content

fix: commentWithDev option apply template #455

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AmirSa12 merged 2 commits into from
Feb 7, 2026
Merged

fix: commentWithDev option apply template #455

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6a3e8ea
fix: `commentWithDev` option apply template
btea Feb 7, 2026
5060fd4
fix: update
btea Feb 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/cli/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -381,6 +381,7 @@ const main = defineCommand({
if (!noDefaultTemplate && templates.length === 0) {
const project = createDefaultTemplate(
Object.fromEntries(deps.entries()),
isCommentWithDev,
);

for (const filePath of Object.keys(project)) {
Expand Down
7 changes: 4 additions & 3 deletions packages/cli/template.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
export const createDefaultTemplate = (
dependencies: Record<string, string>,
isCommentWithDev: boolean,
) => ({
"index.js": "",
"README.md": `
Expand All @@ -17,7 +18,7 @@ ${Object.values(dependencies)
.map(
(url) => `
\`\`\`sh
npm i ${url}
npm i ${url + (isCommentWithDev ? " -D" : "")}
\`\`\`
`,
)
Expand All @@ -28,7 +29,7 @@ npm i ${url}
To use this feature as a maintainer, you can run the following command:

\`\`\`sh
npx pkg-pr-new publish './packages/A' --template './examples/*'
npx pkg-pr-new publish './packages/A' --template './examples/*'${isCommentWithDev ? " --commentWithDev" : ""}
\`\`\`

## Benefits
Expand All @@ -43,7 +44,7 @@ npx pkg-pr-new publish './packages/A' --template './examples/*'
version: "1.0.0",
description: "generated by pkg.pr.new",
main: "index.js",
dependencies,
[isCommentWithDev ? "devDependencies" : "dependencies"]: dependencies,
keywords: [],
author: "pkg.pr.new",
license: "ISC",
Expand Down
Loading