Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 16 additions & 2 deletions packages/app/server/routes/multipart/create.post.ts
Original file line number Diff line number Diff line change
@@ -1,8 +1,12 @@
import { isWhitelisted } from "@pkg-pr-new/utils";
import { isValidGitHash, isWhitelisted } from "@pkg-pr-new/utils";
import { joinKeys } from "unstorage";

export default eventHandler(async (event) => {
const { "sb-key": workflowKey, "sb-name": packageName } = getHeaders(event);
const {
"sb-key": workflowKey,
"sb-name": packageName,
"sb-sha": shaOverride,
} = getHeaders(event);

if (!workflowKey) {
throw createError({
Expand Down Expand Up @@ -35,6 +39,16 @@ export default eventHandler(async (event) => {
});
}

if (shaOverride) {
if (!isValidGitHash(shaOverride)) {
throw createError({
statusCode: 400,
message: "Invalid sb-sha: must be a valid hexadecimal SHA",
});
}
workflowData.sha = shaOverride;
}

const binding = useBinding(event);

const base = `${workflowData.owner}:${workflowData.repo}:${workflowData.sha}`;
Expand Down
2 changes: 1 addition & 1 deletion packages/app/server/routes/publish.post.ts
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ export default eventHandler(async (event) => {
if (!isValidGitHash(shaOverride)) {
throw createError({
statusCode: 400,
message: "Invalid sb-sha: must be a 40-character hex SHA",
message: "Invalid sb-sha: must be a valid hexadecimal SHA",
});
}
workflowData.sha = shaOverride;
Expand Down
1 change: 1 addition & 0 deletions packages/cli/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -517,6 +517,7 @@ const main = defineCommand({
headers: {
"sb-key": key,
"sb-name": name.slice("package:".length),
"sb-sha": sha,
},
});
if (!createMultipartRes.ok) {
Expand Down
Loading