Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions packages/app/e2e.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
);
const gitRevParse = gitRevParseOutput.trim();

beforeAll(async () => {

Check failure on line 27 in packages/app/e2e.test.ts

View workflow job for this annotation

GitHub Actions / ci

e2e.test.ts

Error: Hook timed out in 70000ms. If this is a long-running hook, pass a timeout value as the last argument or configure it globally with "hookTimeout". ❯ e2e.test.ts:27:1
tempDir = await fs.mkdtemp(path.join(os.tmpdir(), E2E_TEMP_DIR_PREFIX));

const app = simulation({
Expand Down Expand Up @@ -153,6 +153,9 @@
expect(process.stderr).toContain("pkg-pr-new:");
expect(process.stderr).toContain("playground-a:");
expect(process.stderr).toContain("playground-b:");
expect(process.stderr).toContain(
"private-playground/ because the package is private",
);
}, 20_000);

it(`serves and installs playground-a for ${mode}`, async () => {
Expand Down
13 changes: 5 additions & 8 deletions packages/cli/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -274,16 +274,13 @@ const main = defineCommand({
const pJsonPath = path.resolve(p, "package.json");
const pJson = await readPackageJson(pJsonPath);

if (!pJson) {
if (!pJson || pJson.private) {
continue;
}

if (!pJson.name) {
throw new Error(`"name" field in ${pJsonPath} should be defined`);
}
if (pJson.private) {
continue;
}

const packageName = pJson.name;
packageInfos.push({ packageName, pJson });
Expand Down Expand Up @@ -471,15 +468,15 @@ const main = defineCommand({
}

try {
if (pJson.private) {
console.warn(`skipping ${p} because the package is private`);
continue;
}
if (!pJson.name) {
throw new Error(
`"name" field in ${pJsonPath} should be defined`,
);
}
if (pJson.private) {
console.warn(`skipping ${p} because the package is private`);
continue;
}

const { filename, shasum } = await resolveTarball(
packMethod,
Expand Down
3 changes: 3 additions & 0 deletions playgrounds/private-playground/package.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
{
"private": true
}
2 changes: 2 additions & 0 deletions pnpm-lock.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading