refactor: Nan to node-addons-api/fix for bun compatibility #332
Open
x8BitRain wants to merge 6 commits intostackgl:masterfrom
Open
refactor: Nan to node-addons-api/fix for bun compatibility #332x8BitRain wants to merge 6 commits intostackgl:masterfrom
x8BitRain wants to merge 6 commits intostackgl:masterfrom
Conversation
Member
|
I've been meaning to work on this someday. Thanks for contributing this. I'll review this over the next while, but on cursory look, it looks good. Tests passing on their first go is also promising. When merged, this will likely go into v10 of this project. I'll also have to spend some time reading more about node-addons type packages, and what changes, if any, will need to be made for packaging up the release. It being re-written in TS will also require some changes from me, such as updating the code linting/formatting, and excluding the derived JS files (I might prefer to exclude them, and only distribute the "built" files to npm) |
Member
|
This will also close #211 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #296
This is a major refactor away from nan and towards node-addons-api that we found was necessary in order for headless-gl to work under a Bun runtime, the downside is older node versions <8 will not support this lib without Nan. Our fork works on Bun 1.3.11 and Node v24.13.1 but if this refactor is undesirable for backwards compatibility purposes then please feel free to close.
I got libEGL.dylib from
./Contents/Frameworks/Google Chrome Framework.framework/Versions/146.0.7680.178/Libraries/libEGL.dyliband libGLESv2.dylib from./Contents/Frameworks/Google Chrome Framework.framework/Versions/146.0.7680.165/Libraries/libEGL.dylibin case you wanted to verify authenticity of the binaries.AI disclaimer: Claude code was used during this refactor.