fix: add condition to execute socket services#65
Open
btravouillon wants to merge 1 commit intostackhpc:masterfrom
Open
fix: add condition to execute socket services#65btravouillon wants to merge 1 commit intostackhpc:masterfrom
btravouillon wants to merge 1 commit intostackhpc:masterfrom
Conversation
When listen_address is not defined (default), the drop-in files are not created. Make sure the role will not try to manage the non-existing services.
6621690 to
bd896df
Compare
|
Hi @btravouillon, thanks for the patch. I think the code is working as expected - it should be possible to start the units without a listen address. Perhaps for some reason on your system you don't have the libvirt socket systemd units? I think that would give the error above, which would be avoided by creating drop-in units, and therefore defining the socket services. What OS are you using? |
Author
This is Ubuntu 18.04. Indeed the socket systemd units do not exist. I should check 20.04 or 22.04. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When listen_address is not defined (default), the drop-in files are not created. Make sure the role will not try to manage the non-existing services.
Without this change, the role fails with the error below when none of
libvirt_host_tcp_listen_addressorlibvirt_host_tls_listen_addressare defined: