Conversation
Alex-Welsh
force-pushed
the
nodeGroupSelector
branch
4 times, most recently
from
fe730de to
13113e9
Compare
Alex-Welsh
force-pushed
the
nodeGroupSelector
branch
2 times, most recently
from
d2dd260 to
de44579
Compare
Alex-Welsh
force-pushed
the
nodeGroupSelector
branch
from
de44579 to
16f1dc6
Compare
sd109
reviewed
Dec 4, 2025
Co-authored-by: Scott Davidson <49713135+sd109@users.noreply.github.com>
sd109
approved these changes
Dec 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tested by creating two node groups, allocating LLMs to each of them, and a third with the field empty (for arbitrary scheduling)
Each api pod landed on the right node. Deleted the node group that contained the "free" instanace plus the fixed one. Free instance was recheduled to the other group, fixed one was not.