Skip to content

feat(charts): Add vllm-omni container support in API deployment#157

Open
Banh-Canh wants to merge 1 commit intomainfrom
fgdfgf
Open

feat(charts): Add vllm-omni container support in API deployment#157
Banh-Canh wants to merge 1 commit intomainfrom
fgdfgf

Conversation

@Banh-Canh
Copy link
Copy Markdown
Member

Signed-off-by: Victor Hang vhvictorhang@gmail.com

Signed-off-by: Victor Hang <vhvictorhang@gmail.com>
@Banh-Canh Banh-Canh self-assigned this Apr 23, 2026
@Banh-Canh Banh-Canh requested a review from Alex-Welsh April 23, 2026 08:55
@Banh-Canh
Copy link
Copy Markdown
Member Author

https://docs.vllm.ai/projects/vllm-omni/en/latest/getting_started/quickstart/#online-serving-with-openai-completions-api

i believe we need to run this with --omni flag. I did test running an instance.

@Alex-Welsh
Copy link
Copy Markdown
Member

Are you sure this is required? When I originally tested vllm-omni, this was the default entrypoint (vllm server --omni). Though that was a pre-release. Has that default changed?

@Banh-Canh
Copy link
Copy Markdown
Member Author

Are you sure this is required? When I originally tested vllm-omni, this was the default entrypoint (vllm server --omni). Though that was a pre-release. Has that default changed?

I tested with image: vllm/vllm-omni:v0.18.0

else the container doesn't start with:

ess: exec: "mistralai/Voxtral-4B-TTS-2603": stat mistralai/Voxtral-4B-TTS-2603: no such file or directory: unknown 

Comment thread charts/azimuth-llm/templates/api/deployment.yml
@Alex-Welsh
Copy link
Copy Markdown
Member

LGTM, just one question. I'm happy with this either way though

@Banh-Canh
Copy link
Copy Markdown
Member Author

LGTM, just one question. I'm happy with this either way though

I think it's fine as it is, so the upstream provider can just do whatever it wants and it won't have to update the entrypoint here (at least, hopefully most of the time)

For omni we have to.. but well that's how omni is packaged so..

thanks for the review

Copy link
Copy Markdown
Member

@Alex-Welsh Alex-Welsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe these are the default entrypoints already

@Banh-Canh
Copy link
Copy Markdown
Member Author

I believe these are the default entrypoints already

Yes so that's why we want to let upstream decide what is best for its app, just in case they change the entrypoint, we won't have to update our override

Which is why I would vote to not override forcibly for the base image, the entrypoint !

@Alex-Welsh Alex-Welsh closed this Apr 27, 2026
@Alex-Welsh Alex-Welsh reopened this Apr 27, 2026
@Alex-Welsh
Copy link
Copy Markdown
Member

Fix for CI not triggering is in progress #159
Once it's merged, rebase and it should work

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants