Conversation
Signed-off-by: Victor Hang <vhvictorhang@gmail.com>
|
i believe we need to run this with --omni flag. I did test running an instance. |
|
Are you sure this is required? When I originally tested vllm-omni, this was the default entrypoint ( |
I tested with else the container doesn't start with: |
|
LGTM, just one question. I'm happy with this either way though |
I think it's fine as it is, so the upstream provider can just do whatever it wants and it won't have to update the entrypoint here (at least, hopefully most of the time) For omni we have to.. but well that's how omni is packaged so.. thanks for the review |
Alex-Welsh
left a comment
There was a problem hiding this comment.
I believe these are the default entrypoints already
Yes so that's why we want to let upstream decide what is best for its app, just in case they change the entrypoint, we won't have to update our override Which is why I would vote to not override forcibly for the base image, the entrypoint ! |
|
Fix for CI not triggering is in progress #159 |
Signed-off-by: Victor Hang vhvictorhang@gmail.com