Skip to content

Commit 83f62de

Browse files
Zuulowenjones
authored andcommitted
Merge "Build Rocky based IPA images"
1 parent b0148ec commit 83f62de

3 files changed

Lines changed: 28 additions & 13 deletions

File tree

ansible/inventory/group_vars/all/ipa

Lines changed: 12 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -23,16 +23,16 @@ ipa_builder_source_version: "{{ openstack_branch }}"
2323
ipa_build_dib_host_packages_extra: [ 'zstd' ]
2424

2525
# List of default Diskimage Builder (DIB) elements to use when building IPA
26-
# images. Default is ["centos", "dynamic-login", "enable-serial-console",
27-
# "ironic-python-agent-ramdisk"] when os_distribution is "rocky", and
28-
# ["ubuntu", "dynamic-login", "enable-serial-console",
26+
# images. Default is ["rocky-container", "dynamic-login",
27+
# "enable-serial-console", "ironic-python-agent-ramdisk"] when os_distribution
28+
# is "rocky", and ["ubuntu", "dynamic-login", "enable-serial-console",
2929
# "ironic-python-agent-ramdisk"] otherwise.
3030
ipa_build_dib_elements_default:
31-
# TODO(mattcrees): Use {{ os_distribution }} here when Rocky IPA builds work.
32-
- "{{ 'centos' if os_distribution == 'rocky' else os_distribution }}"
31+
- "{{ 'rocky-container' if os_distribution == 'rocky' else os_distribution }}"
3332
- dynamic-login
3433
- enable-serial-console
3534
- ironic-python-agent-ramdisk
35+
- baremetal
3636

3737
# List of additional Diskimage Builder (DIB) elements to use when building IPA
3838
# images. Default is none.
@@ -48,8 +48,9 @@ ipa_build_dib_elements: >
4848
# Dictionary of default environment variables to provide to Diskimage Builder
4949
# (DIB) during IPA image build.
5050
ipa_build_dib_env_default:
51-
# TODO(mattcrees): Use {{ os_release }} here when Rocky IPA builds work.
52-
DIB_RELEASE: "{{ '9-stream' if os_distribution == 'rocky' else os_release }}"
51+
DIB_RELEASE: "{{ os_release }}"
52+
DIB_CONTAINERFILE_RUNTIME: "{{ container_engine }}"
53+
DIB_CONTAINERFILE_RUNTIME_ROOT: "{{ (container_engine == 'podman') | int }}"
5354
DIB_REPOLOCATION_ironic_python_agent: "{{ ipa_build_source_url }}"
5455
DIB_REPOREF_ironic_python_agent: "{{ ipa_build_source_version }}"
5556
DIB_REPOREF_requirements: "{{ ipa_build_source_version }}"
@@ -84,8 +85,10 @@ ipa_build_dib_git_elements_extra: []
8485
ipa_build_dib_git_elements: >-
8586
{{ ipa_build_dib_git_elements_default + ipa_build_dib_git_elements_extra }}
8687

87-
# List of DIB packages to install. Default is empty list.
88-
ipa_build_dib_packages: []
88+
# List of DIB packages to install. Default is ["python3-yaml"] when
89+
# when os_distribution is "rocky", otherwise [].
90+
ipa_build_dib_packages: >-
91+
{{ ["python3-yaml"] if os_distribution == 'rocky' else [] }}
8992

9093
# Upper constraints file for installing packages in the virtual environment
9194
# used for building IPA images. Default is {{ pip_upper_constraints_file }}.

etc/kayobe/ipa.yml

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -23,9 +23,9 @@
2323
#ipa_build_dib_host_packages_extra:
2424

2525
# List of default Diskimage Builder (DIB) elements to use when building IPA
26-
# images. Default is ["centos", "dynamic-login", "enable-serial-console",
27-
# "ironic-python-agent-ramdisk"] when os_distribution is "rocky", and
28-
# ["ubuntu", "dynamic-login", "enable-serial-console",
26+
# images. Default is ["rocky-container", "dynamic-login",
27+
# "enable-serial-console", "ironic-python-agent-ramdisk"] when os_distribution
28+
# is "rocky", and ["ubuntu", "dynamic-login", "enable-serial-console",
2929
# "ironic-python-agent-ramdisk"] otherwise.
3030
#ipa_build_dib_elements_default:
3131

@@ -64,7 +64,8 @@
6464
# ipa_build_dib_git_elements_default and ipa_build_dib_git_elements_extra.
6565
#ipa_build_dib_git_elements:
6666

67-
# List of DIB packages to install. Default is empty list.
67+
# List of DIB packages to install. Default is ["python3-yaml"] when
68+
# when os_distribution is "rocky", otherwise [].
6869
#ipa_build_dib_packages:
6970

7071
# Upper constraints file for installing packages in the virtual environment
Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,11 @@
1+
---
2+
upgrade:
3+
- |
4+
Rocky Linux based Ironic Python Agent images are now built in Rocky Linux
5+
based deployments rather than CentOS Stream:
6+
``ipa_build_dib_elements_default`` uses ``rocky-container`` element;
7+
``ipa_build_dib_packages`` includes the ``python3-yaml`` package;
8+
``ipa_build_dib_env_default`` uses specified ``os_release``;
9+
and container runtime is set to ``container_engine``.
10+
- |
11+
``baremetal`` element now included in ``ipa_build_dib_elements_default``

0 commit comments

Comments
 (0)