Synchronise master with upstream#889
Merged
Merged
Conversation
Add healthcheck for Alertmanager container. Change-Id: I990829fb57cc59bf1d0b594cda550d3969db9120 Signed-off-by: Piotr Milewski <vurmil@gmail.com>
The OVN SB relay port was generated using string concatenation between the port prefix and relay group ID. When the relay count exceeded 9, this resulted in invalid port numbers such as 166410. Update the port calculation to use numeric addition instead, ensuring ports remain within the expected and valid range. Closes-Bug: #2131191 Change-Id: I4738339431483c3d38fb322c18888fe61cae1a62 Signed-off-by: amir58118 <sahahmadi96@gmail.com> Signed-off-by: Michal Nasiadka <mnasiadka@gmail.com>
Due to implementation choices in qemu and libvirt, standard log rotate does not work on these console files, and instead the usual approach is to have libvirt's virtlogd rotate the contents of the console log file when it gets a bit big. OpenStack Compute knows how to read data from more than one rotated console log file if required to service a REST API request. OpenStack Kolla and Kolla-Ansible deploy OpenStack components in docker or podman containers. An error in the startup configuration for the nova_libvirt container results in the libvirt virtlogd daemon not being run, which results in this console log rotation not occurring. This opens up the risk of a disk usage denial of service attack on a hypervisor. The console log is stored on the same filesystem as ephemeral disks, and OpenStack Nova will take a hypervisor out of service if disk space becomes constrained. There is some protection from the instance console not being able to write data particularly quickly, but it is definitely still possible to fill the hypervisor file system -- especially if multiple instances are used. This misconfiguration appears to exist in all versions of Kolla / Kolla-Ansible as best as I can tell. Flip qemu.conf's stdio_handler from "file" to "logd" so libvirt routes instance console chardevs through virtlogd, which rotates them per /etc/libvirt/virtlogd.conf. Without this, virtlogd runs but is never consulted and console.log grows unbounded. Partial-Bug: 2155214 Depends-On: https://review.opendev.org/c/openstack/kolla/+/993065 Change-Id: Ia543939b17cd06714695dff8ef8bd29bc3f8175e Signed-off-by: Michael Still <mikal@stillhq.com>
Change-Id: I9cc6b92c15596749d5da30808ff68e51d1dd7765 Signed-off-by: Michal Nasiadka <mnasiadka@gmail.com>
… exist Closes-Bug: #2156582 Change-Id: Ibe6fc69cdd169887054afff37fef824ac7e76d4b Signed-off-by: Michal Nasiadka <mnasiadka@gmail.com>
Remove obsolete monitor user creation task left from the HAProxy to ProxySQL transition. Change-Id: I7c0e9400b07353e0ab807fed43e3561719c060e9 Signed-off-by: Michal Arbet <michal.arbet@ultimum.io>
So far, the test-proxysql.sh has been failing silently because mariadb package was never installed before the test. Improved the test by converting it to Ansible playbook and ensure required packages are installed. Change-Id: I5a6f9599e83cb2ea32ae7a16764967e6c8b73eda Signed-off-by: Seunghun Lee <seunghun@stackhpc.com>
This removes deprecated options from the Horizon settings template (_9998-kolla-settings.py) to clean up the config: TEMPLATE_DEBUG: Removed in Django 1.8, no longer supported. enable_lb, enable_firewall, enable_vpn: These legacy Neutron features were extracted into separate projects (like Octavia). These flags have no effect in modern Horizon deployments. Change-Id: I0740b63a911afe4af07b18e7e374494f686ce504 Signed-off-by: Piotr Milewski <vurmil@gmail.com>
Set the Ironic tempdir to be within the Ironic Docker container volume. Closes-Bug: #2156758 Change-Id: Ib24a04657f297ebb323686aa1d80f9bf019f44f2 Signed-off-by: Jed Preist <jed@stackhpc.com>
This reverts commit 19ad49c. Reason for revert: Re-enable after fixing Signed-off-By: Michal Nasiadka <mnasiadka@gmail.com> Change-Id: Ief8d7ef54aa04a96a4b684151acee20af774e125
Change-Id: I64eb200fadd7357328f7b360db34549759374549 Signed-off-by: Michal Nasiadka <mnasiadka@gmail.com>
Change-Id: I03170d8269068448547c5211ee8aa7e4ec8dcf8e Signed-off-by: Michal Nasiadka <mnasiadka@gmail.com>
Cinder has merged support for VAST [1]. This patch allows Cinder to optionally use VAST as a backend in Kolla Ansible. [1] https://review.opendev.org/c/openstack/cinder/+/939005 Change-Id: I1e35c0c214dc3d10ef2ee31a213b05c499319387 Signed-off-by: John Garbutt <john.garbutt@stackhpc.com> Signed-off-by: Doug Szumski <doug@stackhpc.com>
VAST uses NVME-over-TCP to implement Cinder volumes. In a similar way to iSCSI, this requires extra considerations for Glance when using Cinder as backend store: * The glance-api container must be launched privileged * The /dev filesystem must be accessible from within the glance-api container Closes-Bug: #2144821 Change-Id: Iecf8305f22baac3adb466459b084f0e233b3a75b Signed-off-by: Stig Telfer <stig@stackhpc.com> Signed-off-by: Doug Szumski <doug@stackhpc.com>
github-actions
Bot
added
automated
priteau
approved these changes
Jun 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains a snapshot of master from upstream master.