Synchronise master with upstream#894
Merged
Merged
Conversation
Keystone add support to attribute mapping schema versioning. Therefore, it is interesting to also support this mechanism in Kolla-ansible. The use of "schema_version" option in the attribute mapping is optional; if none is provided, the default defined in Keystoen will be used. Depends-On: https://review.opendev.org/#/c/749572/ Change-Id: I4e6d751330effc0bfeaaded9280a6e64c080e40f Signed-off-by: Rafael Weingärtner <rafael@apache.org> Co-Authored-by: Taavi Ansper <taaviansperr@gmail.com>
This commit changes the default behavior on user creation from 'always update' to 'only set on creation' for passwords. This ensures that by default, operators do not reset their passwords upon every reconfigure run, which causes token invalidation and can lead to unexpected outages. Change-Id: I1787cf7bd99debee6103cec648e21978b25a44cb Signed-off-by: Bertrand Lanson <bertrand.lanson@infomaniak.com>
Remove a stray trailing quote from the barbican_api healthcheck URL. The quote causes shell parsing failures, incorrectly marking the container as unhealthy. Closes-Bug: #2157639 Change-Id: I3e9b791d0ee2ce54af862f3e30e37e6600a350bd Signed-off-by: Piotr Milewski <vurmil@gmail.com>
Change-Id: I3ba831036c7da9b4bb20b9b9beeabf9fdcefe9a8 Signed-off-by: Michal Nasiadka <mnasiadka@gmail.com>
Change-Id: I2fbf5b2b29c2c0071dd560223982a55b1b288e6d Signed-off-by: Michal Nasiadka <mnasiadka@gmail.com>
During container config comparison, podman's Docker-compat exec API inconsistently demultiplexes the 8-byte frame headers from the output stream depending on podman version, leaving binary bytes in raw_output. This will raise an "UnicodeDecodeError: 'utf-8' codec can't decode byte 0x?? in position 167: invalid start byte" Closes-Bug: 2153943 Change-Id: Ida1c017f50b9a24b88f8962d304eb015fa357211 Signed-off-by: Ettore Simone <ettore.simone@gmail.com>
Ironic Conductor does not need to be privileged since the drop of iscsi in Xena release [1]. [1]: I2cd6bf7b27fe0be2c08104b0cc37654b506b2e62 Closes-Bug: #2158011 Change-Id: I81a23970be40334db158829ffebd9fa5f2f192bb Signed-off-by: Michal Nasiadka <mnasiadka@gmail.com>
The libvirt daemon ships with max_workers=20 and max_client_requests=5. Those defaults suit a multi-tenant host serving many mutually distrustful clients, where the per-client request cap protects the daemon from any single client monopolising it. Under Kolla-Ansible, nova-compute is effectively the sole privileged client of libvirtd, so the cap of 5 concurrent requests per client becomes the binding constraint rather than a safety net. When several instances build at once -- as they do during the tempest run of the upgrade jobs -- nova-compute's concurrent libvirt RPCs (instance defineXML calls plus the resource-tracker periodic) exceed five. Further requests queue, the connection's keepalive responses are starved, and after keepalive_interval (5s) x keepalive_count (5) = 25s libvirtd closes the connection. nova then sees "Cannot recv data: Input/output error" mid-defineXML, the build is rescheduled, and once all hosts are exhausted the instance is left in ERROR. This presents as flaky upgrade-job failures. Example failure, on the voting kolla-ansible-debian-bookworm-upgrade job (stable/2025.2): https://zuul.opendev.org/t/openstack/build/73ff5a97567d4e05b1774170e0f4aada with primary/logs/kolla/libvirt/libvirtd.txt showing libvirt's own recommendation to tune this parameter: warning : Client hit max requests limit 5. This may result in keep-alive timeouts. Consider tuning the max_client_requests server parameter ... error : connection closed due to keepalive timeout Raise the per-client cap to 20 -- comfortably above the handful of concurrent builds plus periodics seen in practice -- and the worker pool to 50 so that lifting the per-client limit does not starve other connections such as live migration, health checks and periodic tasks. Both values are exposed as variables (libvirt_max_client_requests and libvirt_max_workers) so operators can tune them further. This is not a Kolla-specific workaround -- the stock libvirtd.conf comment warns that setting max_client_requests too low "may cause keepalive timeouts", and since 2022 libvirtd emits the runtime warning quoted above. As Daniel Berrange explained when he added that warning, the keepalive packets "are subject to the 'max_client_requests' limit just like any API calls", so a client that saturates the limit can have its connection dropped: https://lists.libvirt.org/archives/list/devel@lists.libvirt.org/message/5NIJPA7SJVY55VSK7RTEDEHKWOZYJKT6/ Red Hat documents the same tuning for libvirt hosts under load in its knowledge base, notably "Too many active clients are dropping the connection" at https://access.redhat.com/solutions/28146. Assisted-By: Claude Opus 4.8 (1M context, medium effort) Partial-Bug: 2158515 Change-Id: I131c3d4d57dc73ca4dd421cc8f28465248c9830e Signed-off-by: Michael Still <mikal@stillhq.com>
github-actions
Bot
added
automated
Alex-Welsh
approved these changes
Jun 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains a snapshot of master from upstream master.