Skip to content

Commit a2c9db1

Browse files
Zuulopenstack-gerrit
authored andcommitted
Merge "Use assertRaisesRegex"
2 parents a17f962 + 6fd4388 commit a2c9db1

1 file changed

Lines changed: 3 additions & 9 deletions

File tree

magnum/tests/unit/objects/test_objects.py

Lines changed: 3 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -154,16 +154,10 @@ def test_load_in_base(self):
154154
class Foo(base.MagnumPersistentObject, base.MagnumObject):
155155
fields = {'foobar': fields.IntegerField()}
156156
obj = Foo(self.context)
157-
# NOTE(danms): Can't use assertRaisesRegexp() because of py26
158-
raised = False
159-
ex = None
160-
try:
157+
158+
def fail():
161159
obj.foobar
162-
except NotImplementedError as e:
163-
raised = True
164-
ex = e
165-
self.assertTrue(raised)
166-
self.assertIn('foobar', str(ex))
160+
self.assertRaisesRegex(NotImplementedError, 'foobar', fail)
167161

168162
def test_loaded_in_primitive(self):
169163
obj = MyObj(self.context)

0 commit comments

Comments
 (0)